winget-cli icon indicating copy to clipboard operation
winget-cli copied to clipboard

Add experimental argument to open logs folder

Open Trenly opened this issue 3 years ago • 5 comments

  • [x] Have you signed the Contributor License Agreement?
  • [x] Are you working against an Issue?
    • https://github.com/microsoft/winget-cli/issues/2355#issuecomment-1191937273

Microsoft Reviewers: Open in CodeFlow

Trenly avatar Sep 12 '22 01:09 Trenly

Does this argument work with any command? Does it display the help across all commands? Maybe a quick spec would make sense for this one. I'm expecting we need to think about how it would interact with the PowerShell cmdlets as well.

denelon avatar Sep 12 '22 14:09 denelon

Does this argument work with any command?

Yes

Does it display the help across all commands?

Yes

Maybe a quick spec would make sense for this one. I'm expecting we need to think about how it would interact with the PowerShell cmdlets as well.

I think it would be a good consideration, but I would suggest instead speccing out all common arguments; How does verbose logs interact with the cmdlets? How does wait interact?

I also think this could be refined more in the future (hence only mentioning the linked issue, not marking it for closure) as how users interact with logs is a complex subject. I was thinking build in some minimal functionality first, then spec out a larger feature around it?

Trenly avatar Sep 12 '22 14:09 Trenly

Maybe it should be an experimental argument initially then. It allows us to get feedback before releasing it with the GA client if we need to iterate.

denelon avatar Sep 12 '22 14:09 denelon

Yes, I agree we should cover the other types of arguments as well as they relate to PowerShell.

denelon avatar Sep 12 '22 14:09 denelon

Maybe it should be an experimental argument initially then. It allows us to get feedback before releasing it with the GA client if we need to iterate.

Made it experimental

Trenly avatar Sep 12 '22 15:09 Trenly

/azp run

yao-msft avatar Sep 26 '22 23:09 yao-msft

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 26 '22 23:09 azure-pipelines[bot]