winget-cli icon indicating copy to clipboard operation
winget-cli copied to clipboard

Update Labels from Hash Command

Open Trenly opened this issue 3 years ago • 4 comments


Microsoft Reviewers: Open in CodeFlow

Trenly avatar Aug 09 '22 00:08 Trenly

/azp run

florelis avatar Aug 09 '22 16:08 florelis

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 09 '22 16:08 azure-pipelines[bot]

I think it would be good to add a comment about that so that we don't mistakenly localize the strings later.

I thought that's what the Localization Independent View was for? image

Trenly avatar Aug 09 '22 16:08 Trenly

_liv does mean that it is supposed to be loc independent, but it doesn't say why. My first thought when I saw the change was to wonder why it wasn't localized like in the show command, if it was a leftover from when we didn't have localization, and if we needed to update.

The comment is not needed, I just prefer to err on the side of too many comments than too few.

florelis avatar Aug 09 '22 16:08 florelis