winget-cli icon indicating copy to clipboard operation
winget-cli copied to clipboard

Upgrade Loop

Open DanTheMan827 opened this issue 2 years ago • 6 comments

Brief description of your issue

A number of packages are stuck in an upgrade loop that never seems to go away when the upgrade is installed.

One thing all of these packages have in common is that they all are missing the DisplayVersion registry key and either have the version in DisplayName or they don't have it listed at all.

Below is one such example.

Steps to reproduce

winget install DVDStyler
winget upgrade DVDStyler

Expected behavior

No applicable update found.

Actual behavior

Found DVDStyler [AlexThuering.DVDStyler] Version 3.2.1

Environment

Windows Package Manager v1.2.10271
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22000.556
Package: Microsoft.DesktopAppInstaller v1.17.10271.0

DanTheMan827 avatar Mar 18 '22 18:03 DanTheMan827

This has been addressed with winget upgrade --all.

For individual packages, we aren't able to determine if the latest available package is "newer" than the one installed since the package doesn't report its version to Windows Apps & Features.

What kind of behavior would you want to see in this scenario?

denelon avatar Mar 18 '22 18:03 denelon

In the case of this specific package, the version is present within the name of the uninstall entry DVDStyler v.3.2.1

Perhaps also checking for version in the name of the entry would be possible if DisplayVersion doesn't exist?

Here are a few other examples of applications that specify in the name

DVDStyler v3.2.1
HDD Raw Copy Tool v1.10
NAPS2 6.1.2
Resource Hacker Version 5.1.7

DanTheMan827 avatar Mar 18 '22 18:03 DanTheMan827

Unfortunately, we can't trust the "displayName" property as it usually contains a "marketing version" rather than a "software build version".

denelon avatar Mar 18 '22 18:03 denelon

I did submit a PR for the publisher to add the version to ARP - https://sourceforge.net/p/dvdstyler/DVDStyler/merge-requests/3/

Trenly avatar Mar 25 '22 20:03 Trenly

Is this issue resolved with the improvements in Windows Package Manager 1.3?

denelon avatar Aug 08 '22 18:08 denelon

@DanTheMan827 this issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

ghost avatar Aug 15 '22 22:08 ghost

@DanTheMan827 this issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

ghost avatar Jan 04 '23 22:01 ghost