vstest icon indicating copy to clipboard operation
vstest copied to clipboard

Microsoft.NET.Test.Sdk 17.10 breaks MSBuild isolation

Open hotchkj opened this issue 1 year ago • 1 comments

Description

Building any test project with Microsoft.NET.Test.Sdk 17.10.0 or 17.11.0 against MSBuild with the isolate flag on breaks the build. This suggests the package is doing something that it should not be in MSBuild tasks, since isolation is expected to succeed with 'normal' managed projects. This did not apply with 17.9 or earlier, thus appears to be a regression.

Steps to reproduce

  • Create a sample pair of csproj, one src and one test, targeting NET 6 & NET 8
    • No source is required, just the replicating csproj files
  • Reference Microsoft.NET.Test.Sdk 17.10 in the test project as PackageReference
  • Reference the other project src as a ProjectReference in the test project
  • Build the pair of projects as a solution with msbuild /target:Rebuild -isolateProjects:true -graphBuild:true

Expected behavior

The build succeeds.

Actual behavior

The build fails with isolation errors, indicating that the global properties set for each project have been altered during the build.

Workaround

Revert to Microsoft.NET.Test.Sdk 17.9.0, or change to -isolateProjects:false, removing build isolation

Diagnostic logs

N/A - build issue not test issue.

Environment

Windows 10, MSBuild 17.10.4

hotchkj avatar Aug 28 '24 11:08 hotchkj

Thanks for reporting, I will investigate.

nohwnd avatar Aug 29 '24 08:08 nohwnd