vstest
vstest copied to clipboard
Add timers to the TestResult, and update the TRX logger to output the timer information
Add timers to the TestResult, and update the TRX logger output the timer information to the TRX file if any timers are in the collection, as per the XML schema of the TRX from %VSINSTALLDIR%\xml\Schemas\vstst.xsd
It looks almost like an oversight that the TestResult did not previously include the named timers.
Related issues
- The primary motivation for this connects back to testfx#504
- To support testfx#504, the TRX logger has to be updated, as per #2196.
Added fix for failing unit test by adding commit 'df5213197b38378a712a544a6d095975cd737e31' to the pull request.
@singhsarab I addressed your review comments. Thanks for the input. It looks like there was some problem in the build unrelated to my changes (see here). I can't find a way to re-queue a build. Can you provide me any guidance so this doesn't stall ?
@robdalsanto Could you please attach a sample trx with the change ?
We need some tests, acceptance and unit for this change.
@robdalsanto could you make some acceptance tests?
Yes, I am busy now until June. So while I plan to get to this, it won't be right away.
On Mon, Mar 9, 2020 at 11:29 AM Maximilian Chaplin [email protected] wrote:
@robdalsanto https://github.com/robdalsanto could you make some acceptance tests?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/microsoft/vstest/pull/2208?email_source=notifications&email_token=AHOFEGC7XYWMSMWWI4MWKZDRGUYOXA5CNFSM4I4ORNFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOIPMWQ#issuecomment-596702810, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHOFEGESXN6VWJGKESSNZZTRGUYOXANCNFSM4I4ORNFA .
Looks like a nice change, that is only missing tests, adding for consideration in 16.7.0.
@robdalsanto We know it's been a really long time but would you be able to work on the tests or do you want us to take it over?
Hi, Sorry to punt, but yes please take over and create the tests. I thought I'd have time to write them, and agree they are needed. But I don't see an opportunity to fit the task into my schedule anytime soon. Thanks, Rob
On Wed, Aug 3, 2022, 11:58 AM Amaury Levé @.***> wrote:
@robdalsanto https://github.com/robdalsanto We know it's been a really long time but would you be able to work on the tests or do you want us to take it over?
— Reply to this email directly, view it on GitHub https://github.com/microsoft/vstest/pull/2208#issuecomment-1204063265, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHOFEGH64VIPJLAACKX7MFTVXKCKXANCNFSM4I4ORNFA . You are receiving this because you were mentioned.Message ID: @.***>
@robdalsanto No worries, thanks for letting us know!
I'm going to close for stale state.