vstest icon indicating copy to clipboard operation
vstest copied to clipboard

Add timers to the TestResult, and update the TRX logger to output the timer information

Open robdalsanto opened this issue 5 years ago • 11 comments

Add timers to the TestResult, and update the TRX logger output the timer information to the TRX file if any timers are in the collection, as per the XML schema of the TRX from %VSINSTALLDIR%\xml\Schemas\vstst.xsd

It looks almost like an oversight that the TestResult did not previously include the named timers.

Related issues

  • The primary motivation for this connects back to testfx#504
  • To support testfx#504, the TRX logger has to be updated, as per #2196.

robdalsanto avatar Oct 01 '19 20:10 robdalsanto

CLA assistant check
All CLA requirements met.

msftclas avatar Oct 01 '19 20:10 msftclas

Added fix for failing unit test by adding commit 'df5213197b38378a712a544a6d095975cd737e31' to the pull request.

robdalsanto avatar Oct 01 '19 22:10 robdalsanto

@singhsarab I addressed your review comments. Thanks for the input. It looks like there was some problem in the build unrelated to my changes (see here). I can't find a way to re-queue a build. Can you provide me any guidance so this doesn't stall ?

robdalsanto avatar Nov 14 '19 20:11 robdalsanto

@robdalsanto Could you please attach a sample trx with the change ?

singhsarab avatar Nov 26 '19 15:11 singhsarab

We need some tests, acceptance and unit for this change.

singhsarab avatar Nov 26 '19 15:11 singhsarab

@robdalsanto could you make some acceptance tests?

HeroMaxPower avatar Mar 09 '20 18:03 HeroMaxPower

Yes, I am busy now until June. So while I plan to get to this, it won't be right away.

On Mon, Mar 9, 2020 at 11:29 AM Maximilian Chaplin [email protected] wrote:

@robdalsanto https://github.com/robdalsanto could you make some acceptance tests?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/microsoft/vstest/pull/2208?email_source=notifications&email_token=AHOFEGC7XYWMSMWWI4MWKZDRGUYOXA5CNFSM4I4ORNFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOIPMWQ#issuecomment-596702810, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHOFEGESXN6VWJGKESSNZZTRGUYOXANCNFSM4I4ORNFA .

robdalsanto avatar Mar 10 '20 01:03 robdalsanto

Looks like a nice change, that is only missing tests, adding for consideration in 16.7.0.

nohwnd avatar Mar 11 '20 12:03 nohwnd

@robdalsanto We know it's been a really long time but would you be able to work on the tests or do you want us to take it over?

Evangelink avatar Aug 03 '22 14:08 Evangelink

Hi, Sorry to punt, but yes please take over and create the tests. I thought I'd have time to write them, and agree they are needed. But I don't see an opportunity to fit the task into my schedule anytime soon. Thanks, Rob

On Wed, Aug 3, 2022, 11:58 AM Amaury Levé @.***> wrote:

@robdalsanto https://github.com/robdalsanto We know it's been a really long time but would you be able to work on the tests or do you want us to take it over?

— Reply to this email directly, view it on GitHub https://github.com/microsoft/vstest/pull/2208#issuecomment-1204063265, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHOFEGH64VIPJLAACKX7MFTVXKCKXANCNFSM4I4ORNFA . You are receiving this because you were mentioned.Message ID: @.***>

robdalsanto avatar Aug 04 '22 15:08 robdalsanto

@robdalsanto No worries, thanks for letting us know!

Evangelink avatar Aug 04 '22 15:08 Evangelink

I'm going to close for stale state.

MarcoRossignoli avatar Dec 05 '22 13:12 MarcoRossignoli