vstest icon indicating copy to clipboard operation
vstest copied to clipboard

dotnet test html logger throws execption when using special characters in DataRow attributes.

Open nohwnd opened this issue 1 year ago • 2 comments

Cannot move there, see: https://github.com/dotnet/sdk/issues/38983

nohwnd avatar Nov 13 '24 20:11 nohwnd

Is it OK when I start working on that?

daveMueller avatar Dec 23 '24 10:12 daveMueller

I looked a bit into it and think this can only be solved by preprocessing the xml test result before transforming it into html. Like already mentioned in this comment here https://github.com/microsoft/vstest/blob/main/src/Microsoft.TestPlatform.Extensions.HtmlLogger/HtmlTransformer.cs#L33-L35, the test result can contain characters that aren't valid xml. Thus the html writer must also be tolerant of those characters which he isn't anymore after the change in this PR https://github.com/microsoft/vstest/pull/4756. But it also isn't an option to use own XmlWriterSettings again because this will bring back the staircase issue https://github.com/microsoft/vstest/issues/4754.

daveMueller avatar Dec 29 '24 23:12 daveMueller