vscode icon indicating copy to clipboard operation
vscode copied to clipboard

chore: delete wrong-OS node-pty prebuilds

Open rzhao271 opened this issue 1 month ago • 2 comments

Unblocks updating node-pty until we have a better solution in node-pty itself.

rzhao271 avatar Dec 10 '25 16:12 rzhao271

Verification build: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=383769&view=results

I'd also like to check how much the macOS and Linux binaries grow in size.

rzhao271 avatar Dec 10 '25 17:12 rzhao271

I think we should also update the conpty version to v1.23.251008001 that comes with the node-pty bump. https://github.com/microsoft/vscode/pull/282291/files

I'll manually test again once build passes.

/cc @Tyriar

anthonykim1 avatar Dec 10 '25 17:12 anthonykim1

New verification build: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=383805&view=results

rzhao271 avatar Dec 10 '25 18:12 rzhao271

New verification build: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=383817&view=results

rzhao271 avatar Dec 10 '25 18:12 rzhao271

@rzhao271 update the cachesalt, x64 ran with cache that has prebuilds not removed https://dev.azure.com/monacotools/Monaco/_build/results?buildId=383817&view=logs&jobId=12844632-35fb-5b51-892a-9f6fe8a80e65&j=c3c6d686-fd72-58b2-fb22-32758a96abc0&t=43669b33-f7cc-5b15-d4df-074717949166 leading to the universal step failure.

deepak1556 avatar Dec 10 '25 20:12 deepak1556

New verification build: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=383839&view=results

rzhao271 avatar Dec 10 '25 20:12 rzhao271

Closing now that we have https://github.com/microsoft/node-pty/pull/829

rzhao271 avatar Dec 10 '25 21:12 rzhao271