vscode icon indicating copy to clipboard operation
vscode copied to clipboard
verified publisher icon microsoft

Tools picker should honour `workbench.quickOpen.closeOnFocusLost` setting

Open jrieken opened this issue 2 weeks ago • 1 comments

  • enable workbench.quickOpen.closeOnFocusLost (default is to be enabled)
  • open tools picker
  • focus out
  • :bug: tools picker stays open

jrieken avatar Dec 10 '25 15:12 jrieken

This is the reason it happens: https://github.com/microsoft/vscode/blob/c05e0b2311b14c98609d01ed06eaa464b22e1b2c/src/vs/workbench/contrib/chat/browser/actions/chatToolPicker.ts#L462 IQuickInput.ignoreFocusOut is set to true, which cause it to ignore workbench.quickOpen.closeOnFocusLost. It seems to be an intentional design choice.

SalerSimo avatar Dec 10 '25 17:12 SalerSimo

I don't know the history of it, but I think we should change that. I'm not aware of other quick picks that are sticky.

aeschli avatar Dec 11 '25 08:12 aeschli

I can open a PR to address this, but it could be helpful to tag the original author first, to understand the reasoning behind the current implementation.

SalerSimo avatar Dec 11 '25 09:12 SalerSimo