vscode icon indicating copy to clipboard operation
vscode copied to clipboard

Agents sessions: indicate need for user input like approvals

Open rebornix opened this issue 1 month ago • 10 comments

Testing #274477

Image

When an agent session requests permission, we may want to render this info on the list view so users know they need to come back to the agent session to provide feedback.

rebornix avatar Nov 07 '25 23:11 rebornix

I wonder if we should introduce a new state along side running/cancelled/finished to indicate this. Basically a 4th state for input by user needed? And we would use this in many situations:

  • confirmation for tool call
  • follow up question

bpasero avatar Nov 08 '25 07:11 bpasero

Besides the UX piece, this needs some kind of new API and adoption for all providers.

bpasero avatar Nov 21 '25 16:11 bpasero

fyi @jo-oikawa @mrleemurray our designs need to include this state: a session is in progress but also stuck on user input

bpasero avatar Nov 28 '25 15:11 bpasero

related: https://github.com/microsoft/vscode/issues/280617

connor4312 avatar Dec 02 '25 15:12 connor4312

See feedback also from https://github.com/microsoft/vscode/issues/281590 (as part of https://github.com/microsoft/vscode-internalbacklog/issues/6388).

bamurtaugh avatar Dec 05 '25 21:12 bamurtaugh

For now I merged the fix that surfaces the confirmation to the user. We can explore something else in the future about making it actionable from the same view

osortega avatar Dec 06 '25 00:12 osortega

I really think we need something stronger. Lets work on it in December/January, this should surface to the user with a stronger indicator on a session card.

//cc @jo-oikawa @eli-w-king

bpasero avatar Dec 07 '25 15:12 bpasero

I have some existing stuff I want to clean up around tool confirmation state (like moving the window notifications out of the rendering logic.) And as part of this additional work I would love to have the tool requiring input shown on hover on the session.

So I would be more than happy to take this on for dec/jan :)

connor4312 avatar Dec 09 '25 23:12 connor4312

Warning icon in yellow + update subheader to something like "Input needed"?

Image

jo-oikawa avatar Dec 10 '25 02:12 jo-oikawa

@roblourens , @osortega and me will drive this. Me from UX, others from core.

bpasero avatar Dec 10 '25 16:12 bpasero

@osortega can you backport your changes to recovery?

bpasero avatar Dec 13 '25 07:12 bpasero