vscode icon indicating copy to clipboard operation
vscode copied to clipboard

Chat - Apply in Editor feedback

Open lszomoru opened this issue 5 months ago • 5 comments

Steps to Reproduce:

  1. Used the /plan prompt to have Copilot create a plan for the changes
  2. The respose included some code changes:
    • "Apply in Editor" should be rendered as a primary action
    • Clicking "Apply in Editor" asks me for a file even though based on the response it should now which file to udpate
Image

For insertions and deletions I think that the code block in the chat panel should have diff decoration (red/green). In the case of the screenshot above it would have been super helpful if the two added lines would have been highlighted.

//cc @bpasero, @isidorn

lszomoru avatar Jul 15 '25 10:07 lszomoru

@lszomoru interesting, so the plan prompt disables the edit tool, as such AI falls back to showing suggested edits like this. But the idea is not to apply them from this stage, rather to reason about it.

Nevertheless, your feedback for edits applies to edit mode as well.

bpasero avatar Jul 15 '25 12:07 bpasero

asks me for a file even though based on the response it should now which file to udpate

implies that it didn't output a codeblock with a proper filepath comment

roblourens avatar Jul 15 '25 16:07 roblourens

Isn't the problem that you were asking it to write a plan, not implement it? I don't think we should spend a lot of time optimizing this button-clicking flow vs a normal agent flow

roblourens avatar Jul 15 '25 16:07 roblourens

"Apply in Editor" should be rendered as a primary action

What does that mean?

aeschli avatar Dec 10 '25 16:12 aeschli

An action with the accent color, in case we are doing that when rendering code blocks.

lszomoru avatar Dec 10 '25 16:12 lszomoru