vscode icon indicating copy to clipboard operation
vscode copied to clipboard

fix: correct OS_ID parsing for quoted values (Fix #232159)

Open TylerAustinW opened this issue 6 months ago • 1 comments

This PR fixes #232159.

When /etc/os-release contains quoted values (e.g. ID="rocky") the previous grep/sed pipeline failed to capture the ID, causing check-requirements-linux.sh to exit early and block devcontainer start-up on Rocky 8.5 and similar distributions.

Implementation notes:

  • Source the file in a subshell (. /etc/os-release) and echo $ID, stripping embedded quotes with ${ID//"/}. This is POSIX-compatible and correctly handles both quoted and unquoted formats.
  • No other logic changes.

Tested on:

  • Rocky 8.5 — script now succeeds and detects GLIBC versions.
  • Ubuntu 22.04 — behaviour unchanged.

No lint or CI failures (yarn compile, yarn test) on local run.

TylerAustinW avatar Jun 16 '25 14:06 TylerAustinW