vscode icon indicating copy to clipboard operation
vscode copied to clipboard

Task terminal icon has color glitch

Open anthonykim1 opened this issue 7 months ago • 2 comments

Resolves: https://github.com/microsoft/vscode/issues/234602

For me, the icon is always white color (regardless of hover&focused), even when task terminal is in failed/error state. I made some changes in the taskTerminalStatus.ts file, but then this makes the icon ALWAYS red for failed/error state task terminal.

I'm thinking there may be some focused/hover related thing I might be missing @meganrogge

anthonykim1 avatar May 22 '25 20:05 anthonykim1

After this PR I get: Screenshot 2025-05-22 at 12 29 24 PM and Screenshot 2025-05-22 at 12 29 21 PM

whereas before, the tool icon is always white: Screenshot 2025-05-22 at 1 03 27 PM

anthonykim1 avatar May 22 '25 20:05 anthonykim1

@anthonykim1 we want the icon to stay red for as long as the task has errors -- is that what happens via this PR?

meganrogge avatar May 23 '25 16:05 meganrogge

@anthonykim1 in reply to https://github.com/microsoft/vscode/issues/224750#issuecomment-3221220034, yes. However, that issue is locked so I cannot leave a reply. Can you please unlock it and I can provide more details.

maxpatiiuk avatar Aug 25 '25 18:08 maxpatiiuk