fix: missing translations of remote built-in extensions
@BlackHole1 noticed that some translations are missing when develop in remote mode. After digging a bit, we found that only built-in extensions' NLS messages are missing. For example, the Source Control view (contributed by the built-in 'Git' extension) and built-in extensions' configurations are in English.
Despite that the remote server will download and install the corresponding language pack extension, it does not pick the language pack up because of 2 problems:
- There's no
nls.keys.jsonin the server build, causingclp/{hash}.{lang}/*failed to generate. - When scanning built-in extensions, the UI language was not passed correctly to the backend.
This PR fixes the 2 problems.
Note about problem 1: The original code Promise.all([mkdir, read keys, read messages]) will fail when the keys file is missing, but the mkdir task would succeed and leave an empty folder which prevents it regenerate in the next calling. So I changed the testing logic from the folder to the file in it.
@microsoft-github-policy-service agree
Can you please share more information here - what is the bug? Are there steps to reproduce? Any screenshots would be helpful. Before that please file an issue first with all this information. Thanks
@sandy081 Hi thanks for showing up. I have created an issue linked to this PR: https://github.com/microsoft/vscode/issues/250579
@hyrious how did you test this change, because I just tested it (by building a local build of VS Code) and it sadly does not work (I'm using a pseudolanguage pack since I know only English)
@sandy081 your guidance would be nice here. The steps are easy to reproduce:
- Install a language pack
- Do any Remote connection (like Dev Containers)
- Check the source control view for localization
These strings are localized in the manifest so I'm not sure why, when there's a remote, the manifest strings would stick to English.
@TylerLeonhardt A little tricky to test because the remote host should also be built by yourself. If you're using the official reh build in the remote host it wouldn't work.
I actually tested it by manually port changes to the code-server. You may have a try:
- Find the code server's source code in the remote OS, it should be inside ~/.vscode-server.
- Copy the nls.keys.json from your local vscode to the same folder as nls.messages.json in the remote OS.
- Delete the
clpfolder from the remote OS if it was generated before. - Port changes to the server's source code. If you're just lazy, you can hard code a language option in the scan extensions method (see this pr's diff).
- Reconnect to it, this means a full restart of the code-server process. The client should have been modified to send correct IPC messages. Note that in this step, you have to make sure the local commit does not change otherwise the server may refuse to connect.
Delete the clp folder from the remote OS if it was generated before.
clp location: ~/.vscode-server-insiders/data/clp
I built an Insiders build off of this branch and can confirm that this fixes the problem :)
@sandy081 I defer to you for final approval
@TylerLeonhardt Approved from my side. Should we merge?
@hyrious this fix is going to make a lot of devs happy. Thank you for contributing!