Chat-related commands should not be available on web (without backend)

[ulugbekna]

Repro:

1. open insiders.vscode.dev
2. open palette and search "open chat" -> :bug: you see empty panel chat

https://github.com/user-attachments/assets/13fa6695-c191-4d4c-8ecc-ea3741bc1d2e

Version: 1.98.0-insider Commit: ac0e8f0f32e3de145dc3aa11d8182f208a05397f Date: 2025-02-25T05:06:39.916Z Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/133.0.0.0 Safari/537.36

[roblourens]

Chat welcome views are disabled specifically for web here https://github.com/microsoft/vscode/blob/889e7ee6badc4a69f6846456936a5731399ba07c/src/vs/workbench/contrib/chat/common/chatEntitlementService.ts#L116

Here's the when clause for the chat view https://github.com/microsoft/vscode/blob/889e7ee6badc4a69f6846456936a5731399ba07c/src/vs/workbench/contrib/chat/browser/chatParticipant.contribution.ts#L68

It's not really clear what the right thing to change is. Maybe there should be a new context key set at https://github.com/microsoft/vscode/blob/889e7ee6badc4a69f6846456936a5731399ba07c/src/vs/workbench/contrib/chat/browser/chatSetup.ts#L100 saying that setup is disabled vs disabled? Or we set ChatContextKeys.Setup.hidden in this case? @bpasero?

[bpasero]

This is a good catch and we should not only make sure to hide this in web (without remote) but also when a user explicitly did "Hide Copilot" from the UI.

I am going with setting the context key to hidden for web without remote. And I do a pass over commands with "Chat" in their name, but I am probably missing some.

@roblourens if you wanna also check for commands that are wrongly globally enabled, that would be helpful. To verify, a fresh VS Code launch after "Hide Copilot" should not show any traces of copilot in commands or UI.

[roblourens]

Thanks! Just pushed a couple small changes

@rebornix @DonJayamanne can you look at the notebook changes in https://github.com/microsoft/vscode/pull/242954? This command is a bit different because it's contributed by core but also declared by the extension. I think you could remove the command registration in the extension

[vs-code-engineering[bot]]

This bug has been fixed in the latest release of VS Code Insiders!

@ulugbekna, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version 8ebc9a6f21bef915c1373b8d0f57a95b496216dd of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!