vscode icon indicating copy to clipboard operation
vscode copied to clipboard

fix: workbench search use correct findMatch colors (fix #237909)

Open simon-id opened this issue 11 months ago • 1 comments

Motivation

Fixes: #237909

With this user configuration, find match text color are improperly rendered when using Workbench Search (not the widget search):

    "workbench.colorCustomizations": {
        "editor.findMatchHighlightForeground": "#000000",
        "editor.findMatchHighlightBackground": "#ffffb4",
        "editor.findMatchForeground": "#000000",
        "editor.findMatchBackground": "#ff4cde"
    },

Before fix:

image

After fix:

image

Code changes

Add the inlineClassName field to the Workbench Search ModelDecorationOptions to properly render the editor.findMatchForeground and editor.findMatchHighlightForeground colors.

This field is copied directly from the ModelDecorationOptions in src/vs/editor/contrib/find/browser/findDecorations.ts, as the widget search properly renders the foreground colors. https://github.com/microsoft/vscode/blob/37066ba9a9ead9175d059b35124942cde3a4ca82/src/vs/editor/contrib/find/browser/findDecorations.ts#L286-L318

simon-id avatar Jan 14 '25 16:01 simon-id

Failing test looks unrelated and only happen on windows ? looks like a flaky tests but I don't know how to restart the job:

vscode API - network proxy support
       basic auth:
     Error: Unexpected status code (expected 418): 200

https://dev.azure.com/vscode/VSCode/_build/results?buildId=141565&view=logs&j=e5ed5edc-5ec6-5bfb-d1cb-ed7e8a6cb5eb&t=591b7a1b-7322-5ac3-b08e-eb7fe6b0ff14

simon-id avatar Jan 14 '25 22:01 simon-id

@simon-id the Code OSS build is gone, could you please close and reopen the PR to trigger another build?

osortega avatar Jan 30 '25 18:01 osortega

@osortega done!

simon-id avatar Jan 31 '25 09:01 simon-id