vscode icon indicating copy to clipboard operation
vscode copied to clipboard

First service dependency of ChatViewPane at position 3 conflicts with 1 static arguments

Open bpasero opened this issue 1 year ago • 1 comments

Steps to Reproduce:

  1. I am running out of sources without being logged in but with chat extension installed
  2. click on the chat view
[createInstance] First service dependency of ChatViewPane at position 3 conflicts with 1 static arguments

I think the problem is the introduction of this option:

https://github.com/microsoft/vscode/blob/d72a0f0af6edf3601ec95328755841695aa300dd/src/vs/workbench/contrib/chat/browser/chatViewPane.ts#L52

Which is then not passed in here:

https://github.com/microsoft/vscode/blob/d72a0f0af6edf3601ec95328755841695aa300dd/src/vs/workbench/contrib/chat/browser/chatParticipantContributions.ts#L308

vs here:

https://github.com/microsoft/vscode/blob/d72a0f0af6edf3601ec95328755841695aa300dd/src/vs/workbench/contrib/chat/browser/chatParticipantContributions.ts#L341

bpasero avatar Oct 20 '24 08:10 bpasero

I did a quick hack tracing to add this in the same style but still got the exception 🤔

bpasero avatar Oct 20 '24 08:10 bpasero

I think @alexdima fixed this in https://github.com/microsoft/vscode/commit/16ff8ed9ac9ffa2f979429ecf2adb8e6ec4501c7

bpasero avatar Oct 21 '24 15:10 bpasero