vscode icon indicating copy to clipboard operation
vscode copied to clipboard

Visual Studio Code Insiders Crashes on Clicking Ribbon Menu in Version 1.95.0

Open ryandward opened this issue 1 year ago • 21 comments

Type: Bug

  • VS Code Version: 1.95.0_insider+1728048601-1
  • OS Version: Arch Linux

Steps to Reproduce:

  1. Open Visual Studio Code Insiders.
  2. Click on the ribbon at the top where "File" is located.
  3. The application crashes immediately.

Expected Behavior:

The "File" menu should open without causing the application to crash.

Actual Behavior:

Clicking on the ribbon causes the application to crash.

Additional Context:

  • This issue occurs consistently after upgrading to version 1.95.0.
  • Downgrading to version 1.94.0_insider+1727701314-1 resolved the issue, indicating a possible regression in the latest release.
  • Using "Extension Bisect" did not help identify the cause of the issue.

Error Logs:

[716052:1005/134916.942791:FATAL:check.cc(376)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry!
[1005/134916.951322:ERROR:elf_dynamic_array_reader.h(64)] tag not found
[1005/134916.952469:ERROR:elf_dynamic_array_reader.h(64)] tag not found
[1005/134916.961740:ERROR:directory_reader_posix.cc(43)] opendir /home/ryandward/.config/Code - Insiders/Crashpad/attachments/ad3e9791-0dff-41dc-9bee-e58033518366: No such file or directory (2)

Steps Taken to Resolve:

  • Downgraded: Downgraded to version 1.94.0, which worked without crashes.
  • Attempted Workarounds:
    • Ran code-insiders --disable-extensions, but the issue persisted.
    • Deleted configuration files and reinstalled, but the issue remained.
    • Attempted --disable-gpu, which also did not resolve the problem.

VS Code version: Code - Insiders 1.94.0-insider (b7894e64dd103a19dd5015326d8310232236de0f, 2024-09-30T12:16:57.458Z) OS version: Linux x64 6.11.1-arch1-1 Modes:

System Info
Item Value
CPUs Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz (12 x 4347)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: disabled_software
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off
webnn: disabled_off
Load (avg) 1, 2, 1
Memory (System) 125.73GB (117.04GB free)
Process Argv --no-sandbox --crash-reporter-id 82ac9485-e2d2-4cad-988f-73e4fa79c21a
Screen Reader no
VM 0%
DESKTOP_SESSION gnome
XDG_CURRENT_DESKTOP GNOME
XDG_SESSION_DESKTOP gnome
XDG_SESSION_TYPE wayland
Extensions (60)
Extension Author (truncated) Version
project-manager ale 12.8.0
vscode-django bat 1.15.0
gitignore cod 0.9.0
systemd-unit-file coo 1.0.6
python-snippets cst 0.1.2
vscode-tsv cte 0.2.2
vscode-eslint dba 3.0.10
vscode-dash dee 2.4.0
python-extensions-pack dem 1.0.3
git-extension-pack don 0.1.3
githistory don 0.6.20
python-environment-manager don 1.2.4
python-extension-pack don 1.7.0
gitlens eam 15.5.1
vsc-material-theme Equ 34.7.5
vsc-material-theme-icons equ 3.8.8
prettier-vscode esb 11.0.0
code-runner for 0.12.2
copilot Git 1.235.1137
copilot-chat Git 0.22.2024100401
vscode-github-actions git 0.27.0
vscode-pull-request-github Git 0.99.2024100313
gitlab-workflow Git 5.15.0
vscode-test-explorer hbe 2.22.1
path-autocomplete ion 1.25.0
python-resource-monitor kai 0.3.0
aicursor kti 0.5.3
vscode-python-test-adapter lit 0.8.2
rainbow-csv mec 3.12.0
theme-monokai-pro-vscode mon 1.3.2
vscode-apache mrm 1.2.0
vscode-docker ms- 1.29.3
black-formatter ms- 2024.3.12751822
debugpy ms- 2024.11.2024092501
python ms- 2024.16.0
vscode-pylance ms- 2024.9.104
datawrangler ms- 1.11.0
jupyter ms- 2024.10.2024100401
jupyter-keymap ms- 1.1.2
jupyter-renderers ms- 1.0.19
vscode-jupyter-cell-tags ms- 0.1.9
vscode-jupyter-slideshow ms- 0.1.6
remote-containers ms- 0.389.0
test-adapter-converter ms- 0.2.0
nextflow nex 0.3.3
vscode-groovy-lint Nic 3.3.1
vscode-python-typehint njq 1.5.1
indent-rainbow ode 8.3.1
material-icon-theme PKi 5.11.1
r-debugger RDe 0.5.5
r REd 2.8.4
wikitext Row 3.8.2
vs-code-prettier-eslint rve 6.0.0
vscode-djaneiro the 1.4.2
intellicode-api-usage-examples Vis 0.2.8
vscodeintellicode Vis 1.3.1
vscode-icons vsc 12.9.0
jinja who 0.0.8
pretty-ts-errors Yoa 0.6.0
vscode-open-in-github ziy 1.3.6

(2 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805cf:30301675
vsaa593cf:30376535
py29gd2263:31024238
c4g48928:30535728
2i9eh265:30646982
962ge761:30841072
pythongtdpath:30726887
welcomedialog:30812478
pythonnoceb:30776497
asynctok:30898717
dsvsc014:30777825
dsvsc015:30821418
pythonmypyd1:30859725
2e7ec940:31000449
pythontbext0:30879054
accentitlementst:30870582
dsvsc016:30879898
dsvsc017:30880771
dsvsc018:30880772
cppperfnew:30980852
pythonait:30973460
01bff139:31013167
a69g1124:31018687
dvdeprecation:31040973
dwnewjupytercf:31046870
2f103344:31071589
impr_priority:31057980
nativerepl1:31134653
refactort:31084545
pythonrstrctxt:31093868
flighttreat:31119334
wkspc-onlycs-t:31132770
nativeloc1:31118317
wkspc-ranged-t:31151552
cf971741:31144450
e80f6927:31120813
defaultse:31146405
i21gd607:31141543
iacca1:31150324
notype1:31143044
showbadge:31139796
f8igb616:31140137

ryandward avatar Oct 05 '24 19:10 ryandward

Same issue on Debian x86_64 using the version af6645a6, rev 1757 snap which is 1.95.0. Reverting to b7894e64 aka 1.94.0 fix the issue.

jeromerobert avatar Oct 06 '24 10:10 jeromerobert

The c33745f66ce1cd626c3282112671e2a66471ce4f snap (rev 1756) is working properly.

jeromerobert avatar Oct 06 '24 11:10 jeromerobert

Clicking the file menu crashes on Ubuntu 22.04 with the latest two versions:

  • code-insiders_1.95.0-1728049707_amd64.deb
  • code-insiders_1.95.0-1728281106_amd64.deb

summertube avatar Oct 07 '24 13:10 summertube

Same issue here (attempting to open or navigate to the File menu causes a core dump crash, any other menus seem ok) on Ubuntu 20.04, 1.95.0-1728281106, updated with apt from the official vscode repo this morning.

Reverting to 1.95.0-1728049707 doesn't help, but downgrading to 1.95.0-1728022095 does - the File menu no longer crashes with 1728022095 (c33745f).

gpertea avatar Oct 07 '24 13:10 gpertea

Hi there, same issue on Ubuntu 24.04.

Timbuktu1982 avatar Oct 08 '24 11:10 Timbuktu1982

Hi! Same issue here on Linux Mint.

lvoltolini avatar Oct 08 '24 12:10 lvoltolini

Also on Fedora latest

dwconsulting avatar Oct 08 '24 12:10 dwconsulting

Today's update 1.95.0-1728367601 still crashes the same way on Ubuntu.

gpertea avatar Oct 08 '24 14:10 gpertea

Same here with Debian and 1.95.0-1728381467, still crashing on clicking FILE menu. Would really appreciate a fix for this -- I can work around not having access to the FILE menu, short-term, but it's definitely a significant pain point.

I'd switch to stable, but another problem prevents me from doing that, so lacking an easy means to download and reinstall an older (working) Insiders build, I'm kind of stuck. Issues like this actually make a very solid case for keeping prior versions of Insiders builds available, IMO (if they are, short of building from source from some tag I cannot find, I cannot figure out how to do so).

gwiede avatar Oct 08 '24 17:10 gwiede

I have the same issue in Ubuntu 22.04.5 LTS after the latest update. Also the FILE menu specifically

Version: 1.95.0-insider
Commit: a016ec9b66ffdd3ff0f831768b8e75be008a54e4
Date: 2024-10-09T05:04:08.601Z
Electron: 32.1.2
ElectronBuildId: 10323173
Chromium: 128.0.6613.162
Node.js: 20.17.0
V8: 12.8.374.33-electron.0
OS: Linux x64 6.5.0-26-generic

Evizero avatar Oct 09 '24 09:10 Evizero

This morning update for the ubuntu apt repo (1.95.0-1728454020) still hasn't fixed this.

@gwiede if you're using the official apt repo you might be able to downgrade to the previous 1.95 insiders build that doesn't have this silly UI bug -- this works for me in ubuntu 20:

apt install code-insiders=1.95.0-1728022095

gpertea avatar Oct 09 '24 12:10 gpertea

This morning update for the ubuntu apt repo (1.95.0-1728454020) still hasn't fixed this.

@gwiede if you're using the official apt repo...

Nope, IT restrictions. It's okay, I'm coping, just hope they fix it soon, it's kind of ridiculous it slipped through testing.

gwiede avatar Oct 09 '24 16:10 gwiede

Hi! Same issue here on Pop OS. I solved it like as @gpertea solution. I'm waiting to fix bug to update. Thankyou @gpertea

lusacramento avatar Oct 10 '24 18:10 lusacramento

Hi there. The last Update has not fixed the problem

Timbuktu1982 avatar Oct 11 '24 05:10 Timbuktu1982

Update on this crash, it is triggered by the menu item File > New File... (command: welcome.showNewFileEntries) which has accelerator https://github.com/microsoft/vscode/blob/e62dc67d6252105edfffa9b5222546b67538b40a/src/vs/workbench/contrib/welcomeViews/common/newFile.contribution.ts#L34. The runtime on Linux cannot handle Win or Super keys for accelerator shortcut text and they always end up reaching this block https://source.chromium.org/chromium/chromium/src/+/main:ui/base/accelerators/accelerator.cc;l=413 which has not been a fatal call in chromium up until a recent runtime update (despite its name it only logs in release builds and in debug builds it will crash). Chromium has changed its implication in release builds starting with Electron 32 to crash as intended.

For long term, we should handle the shortcut text in Electron to avoid such crashes. Upstream issue https://github.com/electron/electron/issues/44196

I am discussion with @bpasero to get a short term fix in vscode. In the meantime, users can workaround this issue by overwriting the shortcut via Preferences: Open Keyboard Shortcuts and update the shortcut for welcome.showNewFileEntries to exclude the super key.

deepak1556 avatar Oct 11 '24 12:10 deepak1556

Thank you @deepak1556 for the explanation. Indeed, changing that particular shortcut to Ctrl+Shift+Alt+N solves the issue for me and I can use the latest build.

Fortunately I do not have that Windows/Super/meta key assigned to any other shortcuts displayed in the menus. I tested that if I assigned the "meta" key to any other shortcuts exposed in the menus, that is then crashing vscode when THAT menu is to be displayed, as predicted by your explanation.

But this must be one of the silliest UI display bugs I've seen -- just displaying the "Super" text next to a menu item crashing a whole app?!

Especially considering that displaying that same shortcut text in the Keyboard Shortcut dialogs (though the key is also shown as "meta" while the key combo is being recorded), has no such issues on that part of the UI: Image

gpertea avatar Oct 11 '24 13:10 gpertea

Same issue. Selecting "File" menu with and without "--disable-extensions".

Resolution

Steps to workaround [as per above] (https://github.com/microsoft/vscode/issues/230604#issuecomment-2407286823) from deepak1556

  1. Open VS Code (I happen to have the Insiders edition)
  2. Press <ctrl> + <k> then <ctrl> + <s>
  3. in search box add "@source:system welcome.showNewFileEntries" Image
  4. Press <Enter> to select field shown.
  5. In the dialogue box I submitted <ctrl> + <shift> + <atl> + <n>

"File" menu works.


Version: 1.95.0-insider
Commit: 4b4bf8f594077c3dc53ef70518531f64ed566194
Date: 2024-10-11T18:44:53.770Z
Electron: 32.1.2
ElectronBuildId: 10323173
Chromium: 128.0.6613.162
Node.js: 20.17.0
V8: 12.8.374.33-electron.0
OS: Linux x64 6.11.0-8-generic

andibing avatar Oct 12 '24 16:10 andibing

Same issue. Selecting "File" menu with and without "--disable-extensions".

Resolution

Steps to workaround [as per above] (#230604 (comment)) from deepak1556

  1. Open VS Code (I happen to have the Insiders edition)
  2. Press <ctrl> + <k> then <ctrl> + <s>
  3. in search box add "@source:system welcome.showNewFileEntries" Image
  4. Press to select field shown.
  5. In the dialogue box I submitted <ctrl> + <shift> + <atl> + <n>

"File" menu works.

Version: 1.95.0-insider
Commit: 4b4bf8f594077c3dc53ef70518531f64ed566194
Date: 2024-10-11T18:44:53.770Z
Electron: 32.1.2
ElectronBuildId: 10323173
Chromium: 128.0.6613.162
Node.js: 20.17.0
V8: 12.8.374.33-electron.0
OS: Linux x64 6.11.0-8-generic

Thank you, really appreciate you shared your approach to this issue with us. Have a nice sunday

giox79 avatar Oct 13 '24 09:10 giox79

Detected on

Version: 1.95.0-insider
Commit: 62a233cc87dc8d52a817739bc0d917089d4d103b
Date: 2024-10-17T05:09:34.012Z
Electron: 32.1.2
ElectronBuildId: 10323173
Chromium: 128.0.6613.162
Node.js: 20.17.0
V8: 12.8.374.33-electron.0
OS: Linux x64 6.8.0-47-generic

Workaround is ok!!

Image

silvioq avatar Oct 17 '24 15:10 silvioq

Confirming issue. Still crashed with today update. (ubuntu studio 24.04)

Version: 1.95.0-insider Commit: c85acdad6b679973c79b01a38afa91448c705c1c Date: 2024-10-18T07:31:27.077Z Electron: 32.1.2 ElectronBuildId: 10323173 Chromium: 128.0.6613.162 Node.js: 20.17.0 V8: 12.8.374.33-electron.0 OS: Linux x64 6.8.0-47-lowlatency

Workaround works. Thank you for that!!!

artem-korolev avatar Oct 18 '24 15:10 artem-korolev

the same issue for me but the crash occur when mouse hover on "file" button

ascorbic-acid avatar Oct 19 '24 07:10 ascorbic-acid

Same issue here, the workaround works perfectly.

Version: 1.95.0-insider

ghost avatar Oct 22 '24 11:10 ghost

This problem got resolved for me today, see my comment https://github.com/microsoft/vscode/issues/213906#issuecomment-2432740394

merl-dev avatar Oct 23 '24 16:10 merl-dev

Same here, Arch Linux.

Version: 1.95.0
Commit: 912bb683695358a54ae0c670461738984cbb5b95
Date: 2024-10-30T10:28:58.606Z
Electron: 32.2.2
ElectronBuildId: undefined
Chromium: 128.0.6613.186
Node.js: 20.18.0
V8: 12.8.374.38-electron.0
OS: Linux x64 6.11.5-zen1-1-zen

rocketguedes avatar Oct 31 '24 00:10 rocketguedes

Issue is still occurring for me.

Version: 1.95.0 Commit: 912bb683695358a54ae0c670461738984cbb5b95 Date: 2024-10-30T10:28:58.606Z Electron: 32.2.2 ElectronBuildId: undefined Chromium: 128.0.6613.186 Node.js: 20.18.0 V8: 12.8.374.38-electron.0 OS: Linux x64 6.11.5-zen1-1-zen

mbc3 avatar Nov 01 '24 16:11 mbc3

@mbc3 @rocketguedes ElectronBuildId: undefined indicates you are using an unofficial package, please follow https://github.com/microsoft/vscode/issues/232723 which will help get fixes into those packages eventually.

deepak1556 avatar Nov 01 '24 16:11 deepak1556

@mbc3 @rocketguedes ElectronBuildId: undefined indicates you are using an unofficial package, please follow #232723 which will help get fixes into those packages eventually.

thank you, I will wait for the next build of OSS and in the meantime, use the workaround mentioned here to set "window.titleBarStyle" to "custom": https://github.com/microsoft/vscode/issues/232723#issuecomment-2449582575

mbc3 avatar Nov 01 '24 16:11 mbc3

Same here Arch Linux

oisin404 avatar Nov 04 '24 20:11 oisin404

Same here Arch Linux

I also have Arch, and it happened for me.

Reverting to 1.94.0 fixed it.

yay -S downgrade sudo downgrade code

...then choose 1.94.0 from the version list, it's a good interface.

kazvorpal avatar Nov 05 '24 00:11 kazvorpal

Encountered the same issue on both KDE Plama 6 running on Xorg and Wayland, definitely an applicative bug.

System info:

  • OS: Arch Linux (installed 2024/11/10)
  • Kernel: 6.11.6-arch1
  • Architecture: x86_64
  • WM/DE: kwin / Plasma 6.2.3
  • GPU: nvidia unfree driver / Nvidia GTX 970
  • vscode version: Code 1.95.1 (65edc4939843c90c34d61f4ce11704f09d3e5cb6, 2024-11-01T17:20:55.708Z)

The following workaround has been tested and works for me: https://github.com/microsoft/vscode/issues/230604#issuecomment-2407286823

fusetim avatar Nov 10 '24 16:11 fusetim