vscode icon indicating copy to clipboard operation
vscode copied to clipboard

Color of placeholder text of git commit message does not respect setting

Open d-mahard opened this issue 1 year ago • 2 comments

Does this issue occur when all extensions are disabled?: Yes

Version: 1.93.1 (user setup) Commit: 38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40 Date: 2024-09-11T17:20:05.685Z Electron: 30.4.0 ElectronBuildId: 10073054 Chromium: 124.0.6367.243 Node.js: 20.15.1 V8: 12.4.254.20-electron.0 OS: Windows_NT x64 10.0.22631

Steps to Reproduce:

  1. Pick any theme
  2. set "workbench.colorCustomizations": { "editor.placeholder.foreground": "#ff0000"}
  3. expected: placeholder text of git commit message should turn red (or to any color you set) - but actually it stays the default which is "editorGhostText.foreground". Changing the ghost text color indeed also changes this placeholder text color.

I checked using the developer tool that the placeholder text of git commit message is indeed controlled by editor.placeholder.foreground.

see screenshot below

(theme: default dark modern)

image

(theme: wine-bar-monokai)

image

d-mahard avatar Sep 28 '24 22:09 d-mahard

@hediet, is this an issue with the editor placeholder? Thanks!

lszomoru avatar Sep 30 '24 10:09 lszomoru

@hediet @lszomoru May I take this one and create a PR?

d-mahard avatar Jan 14 '25 21:01 d-mahard