vscode icon indicating copy to clipboard operation
vscode copied to clipboard

source control Revert(>)/Stage(+) change buttons no longer work, or are aligned ot the changed block

Open WilliamDAssafMSFT opened this issue 1 year ago • 6 comments

Type: Bug

When using Source Control to view unstaged changed, the Revert(>)/Stage(+) change buttons no longer work, or are aligned ot the changed block.

I used to be able to revert a change with the > button.

Now, nothing happens when I click the > button.

VS Code version: Code 1.93.1 (38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40, 2024-09-11T17:20:05.685Z) OS version: Windows_NT x64 10.0.22635 Modes:

System Info
Item Value
CPUs 11th Gen Intel(R) Core(TM) i7-11370H @ 3.30GHz (8 x 3302)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
webnn: disabled_off
Load (avg) undefined
Memory (System) 31.84GB (5.99GB free)
Process Argv --crash-reporter-id 23e2bccf-b91f-4850-af1e-24dd3f1afe30
Screen Reader yes
VM 0%
Extensions (29)
Extension Author (truncated) Version
vscode-sidebar Acr 1.2.3
Bookmarks ale 13.5.0
LinkCheckMD bla 0.3.1
vscode-markdownlint Dav 0.56.0
docs-article-templates doc 1.0.7
docs-authoring-pack doc 1.0.2
docs-images doc 1.0.4
docs-linting doc 0.0.13
docs-markdown doc 1.0.11
docs-metadata doc 1.0.9
docs-preview doc 1.0.9
docs-scaffolding doc 1.0.8
docs-visual-areas doc 0.2.1
docs-yaml doc 1.0.5
copilot Git 1.234.0
copilot-chat Git 0.20.3
Learn-Training-AI-Assistant Lea 1.1.50
vscode-azurefunctions ms- 1.15.4
vscode-azureresourcegroups ms- 0.9.5
vscode-dotnet-runtime ms- 2.1.6
data-workspace-vscode ms- 0.5.0
mssql ms- 1.24.0
sql-bindings-vscode ms- 0.4.0
sql-database-projects-vscode ms- 1.4.3
remote-wsl ms- 0.88.4
azure-account ms- 0.12.0
powershell ms- 2024.2.2
vscode-yaml red 1.15.0
code-spell-checker str 3.0.1

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
a9j8j154:30646983
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonnoceb:30805159
asynctok:30898717
pythonmypyd1:30879173
2e7ec940:31000449
pythontbext0:30879054
accentitlementsc:30995553
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
0ee40948:31013168
a69g1124:31058053
dvdeprecation:31068756
dwnewjupyter:31046869
impr_priority:31102340
nativerepl2:31139839
refactort:31108082
pythonrstrctxt:31112756
flighttreat:31134774
wkspc-onlycs-t:31132770
nativeloc2:31134642
wkspc-ranged-t:31125599
fje88620:31121564
iacca1:31138162
notype1cf:31143046

WilliamDAssafMSFT avatar Sep 27 '24 20:09 WilliamDAssafMSFT

/gifPlease

lszomoru avatar Sep 30 '24 08:09 lszomoru

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.

If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.

Happy coding!

I am also affected. As can be seen from the screenshot, the arrows do not correspond to actual diffs and clicking arrow button to revert the change does nothing. Not a single one does anything. It started happening recently.

broken_diff

m1lhaus avatar Oct 02 '24 09:10 m1lhaus

@hediet, could you please take a look at this? Thank you!

lszomoru avatar Oct 02 '24 13:10 lszomoru

I upgraded to v1.94.1 today (10/3/2024) and for me the issue I was having with the Revert(>)/Stage(+) change buttons has been resolved. I can bring over changes from the file in the left pane to the file in the right pane by clicking the 'Revert (>)' button. With v1.93.x this button would work for a few files and then stop working and I would need to restart vscode to get it working..but only for a few files again.

If anyone is interested in the issue and how to replicate I have a repository that has files and steps to replicate the Diff Editor revert button bug. https://github.com/MrXcitement/vscode-diff-button-issue

MrXcitement avatar Oct 03 '24 20:10 MrXcitement

I can confirm the issue is gone. I think this can be closed.

m1lhaus avatar Oct 19 '24 16:10 m1lhaus