vscode icon indicating copy to clipboard operation
vscode copied to clipboard

Shouldn't be able to add breakpoint in notebook diff?

Open bamurtaugh opened this issue 1 year ago • 2 comments

Testing #226665

Testing on latest VS Code Insiders on Windows 11 Insiders

Version: 1.93.0-insider (user setup)
Commit: ff7a154d5e5e9034914f0466420f0f1407f0c95e
Date: 2024-08-27T05:04:20.235Z
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Windows_NT x64 10.0.25987

I was surprised I could add a breakpoint. Additionally, the hover gets cut off:

Image

bamurtaugh avatar Aug 27 '24 17:08 bamurtaugh

Breakpoints are allowed in regular python file diffs as well. I think this is allowed.

karthiknadig avatar Aug 27 '24 17:08 karthiknadig

Breakpoints are allowed in regular python file diffs as well. I think this is allowed.

Yes. Why should it be not allowed in the multi file diff editor?

hediet avatar Aug 28 '24 06:08 hediet

Thanks all for clarifying! Then I think my feedback shifts to solely that the hover messages were cut off.

bamurtaugh avatar Aug 28 '24 15:08 bamurtaugh

@pwang347 how best should we verify this? Should we use the same steps from the original TPI https://github.com/microsoft/vscode/issues/226665?

bamurtaugh avatar Nov 06 '25 01:11 bamurtaugh

@bamurtaugh yes please use the original TPI steps

pwang347 avatar Nov 06 '25 01:11 pwang347