vscode icon indicating copy to clipboard operation
vscode copied to clipboard

Source control graph moved into its own view?

Open Tyriar opened this issue 1 year ago • 3 comments

Testing #226648

I don't think I did anything to trigger this, so there might be a bug there?

Screenshot 2024-08-27 at 9 41 49 AM Screenshot 2024-08-27 at 9 42 00 AM

Regardless, it's a little confusing how they are both called Source Control. Shouldn't the first one be called Source Control Graph in this case?

Tyriar avatar Aug 27 '24 16:08 Tyriar

Wow. That looks unexpected. @sandy081, any idea what is going on there?

lszomoru avatar Aug 27 '24 18:08 lszomoru

I do not think views get automatically moved to a custom view container unless it is performed by the user. Can you please share all logs from the machine where this happened?

sandy081 avatar Aug 28 '24 08:08 sandy081

@sandy081 you already have all my logs 😉

Tyriar avatar Aug 28 '24 14:08 Tyriar

Yeah, but I looked for this in the settings sync timeline and it does not seems to appear. So I believe, this seems to happen after you shared the logs.

sandy081 avatar Aug 28 '24 16:08 sandy081

Actually you're right, you have logs from my Windows box and I tested this on my Macbook

Tyriar avatar Aug 28 '24 16:08 Tyriar

Sent them over

Tyriar avatar Aug 29 '24 12:08 Tyriar

Keeping this in the "August 2024" milestone as I would like us to understand why this occurred.

lszomoru avatar Aug 29 '24 13:08 lszomoru

This can happen when the main "Source Control" view ends up in a custom "Source Control" view container (ex: the view is dragged to the side panel, and then back). In this scenario the "Source Control Graph" view will be in the default "Source Control" view container and the user will end up with two view containers. As of right now there is nothing we can do, as we do not have the capability to specify that a view (ex: Source Control Graph) should appear next to another view (ex: Source Control).

lszomoru avatar Sep 02 '24 09:09 lszomoru

Came here to add that I also stumbled upon this state. After upgrading to 1.93.0 from 1.92.0, I noticed that the new Source Control Graph was missing from my Source Control view. I right-clicked in the Activity Bar and noticed Source Control listed twice, but only one was selected. Once I aslo selected the other one, I ended up in the state posted by @Tyriar. I then took this duplicated Source Control (which is actually Sourch Control Graph) and dragged it into my original Source Control and now I have the graph in the default location as expected. I also noticed that after this action, the Activity Bar only shows Source Control once.

MattBudz avatar Sep 11 '24 10:09 MattBudz

Closing the issue as the only solution at the moment is the workaround mentioned https://github.com/microsoft/vscode/issues/226791#issuecomment-2324281567

lszomoru avatar Sep 11 '24 10:09 lszomoru