vscode icon indicating copy to clipboard operation
vscode copied to clipboard

Made Editor Hint reachable by Tab (Fixes #132085)

Open manav014 opened this issue 1 year ago • 1 comments

Fixes #132085

Adds the following features to empty text editor hint

  1. Allow user to navigate across hint options using tab.
  2. Allow user to press escape to directly go to editor.

Steps to Run the code

  1. Build and run the VSCode
  2. Create an Empty File
  3. press tab to move across hint items
  4. press escape to get back to editor.

manav014 avatar Jun 29 '24 21:06 manav014

@microsoft-github-policy-service agree

manav014 avatar Jun 29 '24 21:06 manav014

Hey @joyceerhl . Would be great if you can review this PR.

manav014 avatar Jul 19 '24 19:07 manav014

@joyceerhl could you please take a look at this when you have a moment? Thank you! 🙂

manav014 avatar Jul 29 '24 17:07 manav014

@joyceerhl Thanks a ton for the review. I have implemented the suggestions.

manav014 avatar Jul 31 '24 18:07 manav014

Hey @joyceerhl could this be merged, Or we have anything pending here?

manav014 avatar Aug 05 '24 17:08 manav014

Merge conflict Moving the milestone

rzhao271 avatar Oct 25 '24 22:10 rzhao271

Resolved the conflicts

manav014 avatar Nov 03 '24 13:11 manav014

Build error: emptyTextEditorHint.ts: line 10, col 25, Warning - Imports have to be relative to support ESM (local/code-import-patterns)

rzhao271 avatar Nov 04 '24 22:11 rzhao271