vscode icon indicating copy to clipboard operation
vscode copied to clipboard
verified publisher icon microsoft

`Commit (amend)` is syncing which is not clear

Open TylerLeonhardt opened this issue 1 year ago • 3 comments

Testing #217398

  • Be in this state where you have a local commit already and a staged change:
image
  • Run Commit (Amend):
image

  • Accept the commit message

  • 🐛 the commit does get amended, but then sync changes occurs and my code is pushed: image

I was expect no push/sync since it's in the top section of this menu:

image

TylerLeonhardt avatar Jun 25 '24 21:06 TylerLeonhardt

What is the value of your git.postCommitCommand setting? Thanks!

lszomoru avatar Jun 26 '24 10:06 lszomoru

Yeah it's set to "git.postCommitCommand": "sync",

TylerLeonhardt avatar Jun 26 '24 23:06 TylerLeonhardt

The current implementation is that the command from this setting is executed after all the commit types of actions. I can revisit that.

lszomoru avatar Jun 27 '24 07:06 lszomoru