vscode icon indicating copy to clipboard operation
vscode copied to clipboard

Unsupported OS warning banner will not go away

Open marcbaltes opened this issue 1 year ago • 35 comments

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.86.1
  • OS Version: CentOS 7.9.2009

Steps to Reproduce:

  1. Update VS Code to the latest recovery release
  2. Connect remotely to an machine with an unsupported OS
  3. After connecting a blue banner will persist on the top of the screen

image

I am aware that my OS is unsupported and I can only use VS Code on this machine for another year. I would like to remove this banner at the top of the screen. It's a little annoying and would prefer to not have it constantly showing while working. Is there any way to disable this banner?

marcbaltes avatar Feb 08 '24 14:02 marcbaltes

please have an option to disable it. very annoying

melspectrum avatar Feb 08 '24 15:02 melspectrum

I would also like an option for disabling the banner. The servers I connect to are managed by my organization, and there is nothing I can do to speedup the deployment of new OSes.

marzojr avatar Feb 08 '24 15:02 marzojr

+1 Need option to remove the banner.

kohs100 avatar Feb 08 '24 16:02 kohs100

+1 please add an option to close the banner.

nikoshatzivag avatar Feb 08 '24 19:02 nikoshatzivag

+1 , it is very annoying

hozeren avatar Feb 08 '24 22:02 hozeren

Here's a monkey patch workaround that I've tested on MacOS:

  • Open the workbench desktop JS file. Eg, code /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js
  • Search for return X.create("vs/workbench/contrib/remote/browser/remoteConnectionHealth",e), and replace it with return null.
  • Restart VS Code.
  • Feel that relief of not having a completely pointless (and TBH, a little bit petty) banner across the top of your screen.

There are two notable caveats with this fix:

  • VS Code will complain when opening a new window that the install is corrupt. You can click the gear icon and hide that warning permanently. (Personally, I find it hilarious that you can permanently hide this substantially more important warning, but not the new unsupported OS banner.)
  • The fix will be reset every time VS Code upgrades, but the steps for re-applying the fix should remain the same.

I don't know what the process for monkey patching on Windows or Linux looks like, hopefully someone more familiar with VS Code on those platforms can weigh in!

pento avatar Feb 09 '24 05:02 pento

+1 Option to remove it

saserbest avatar Feb 09 '24 23:02 saserbest

Particular VSCode server files resources/server/bin/helpers/check-requirements-linux.sh and resources/server/bin/code-server-linux.sh should skip requirements check if /tmp/vscode-skip-server-requirements-check file exists.

I tried to create this file on the server and killall node to restart VSCode server - VSCode UI still shows the Alert bar

apivovarov avatar Feb 10 '24 00:02 apivovarov

To remove unsupportedGlibcWarning.banner we need to make isUnsupportedGlibc to be false To do it we can replace isUnsupportedGlibc:k.isUnsupportedGlibc with isUnsupportedGlibc:0 in workbench.desktop.main.js

Mac OS command:

sed -i '' 's/:k\.isUnsupportedGlibc/:0/g' \
"/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js"

apivovarov avatar Feb 10 '24 01:02 apivovarov

+1 Option to remove it

yash760 avatar Feb 10 '24 06:02 yash760

To remove unsupportedGlibcWarning.banner we need to make isUnsupportedGlibc to be false To do it we can replace isUnsupportedGlibc:k.isUnsupportedGlibc with isUnsupportedGlibc:0 in workbench.desktop.main.js

Mac OS command:

sed -i '' 's/:k\.isUnsupportedGlibc/:0/g' \
"/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js"

Works but VSCode is complaining about that the installation is corrupt. https://code.visualstudio.com/docs/supporting/faq#_installation-appears-to-be-corrupt-unsupported

tmeckel avatar Feb 10 '24 16:02 tmeckel

Works but VSCode is complaining about that the installation is corrupt. https://code.visualstudio.com/docs/supporting/faq#_installation-appears-to-be-corrupt-unsupported

Click the cog (gear wheel) icon on that notification, and click "Don't show again".

apivovarov avatar Feb 11 '24 04:02 apivovarov

Is the status as of now to wait for Microsoft to provide a fix for the pesky banner?

serialmetrics avatar Feb 11 '24 23:02 serialmetrics

+1 Option to remove it

fuyw avatar Feb 12 '24 02:02 fuyw

@benibenj, @isidorn I have closed #204944 as this one was already opened for the same issue.

The new status bar at the top has multiple issues and appears to have been punted without much UX reviews,

  1. Cannot dismiss and is jarring.
  2. Does not gel in with the theme colors. On some light and dark themes, it horribly stands out and causes distraction.
  3. On Windows pressing F11, it hampers the full screen mode in which the tabs used to reach the top of the screen. Now it shows an empty menu bar, then this new bar and then the tabs line (occupies extra screen real estate). Essentially, it seems to be blocking the full screen feature towards the top of the screen.

Like I mentioned in #20944, we know we are using old version of VS code, with purpose. Please consider following,

  1. Moving this message to the status bar at the bottom (typical layout); the status bar is supposed to be used for such things (fundamental UX UI principle).
  2. Not changing the background of the message. Should gel with other icons.
  3. For now, just have it show the warning triangle and short message "Unsupported OS" with ALT text of full message on hovering, clicking it should take to the full documentation.
  4. As the D-day nears, the message in the status bar could be made prominent (even blinking red) and optionally use some contrast background if there is a need.

Thanks, WinCPP

WinCPP avatar Feb 12 '24 06:02 WinCPP

+1 Option to remove it

yyxx1997 avatar Feb 12 '24 11:02 yyxx1997

@benibenj, @isidorn I have closed #204944 as this one was already opened for the same issue. 4. As the D-day nears, the message in the status bar could be made prominent (even blinking red) and optionally use some contrast background if there is a need.

No. Nothing should ever blink. Never, seriously!

bitagoras avatar Feb 12 '24 16:02 bitagoras

To remove unsupportedGlibcWarning.banner we need to make isUnsupportedGlibc to be false

To do it we can replace

isUnsupportedGlibc:k.isUnsupportedGlibc

with

isUnsupportedGlibc:0

in

workbench.desktop.main.js

Mac OS command:


sed -i '' 's/:k\.isUnsupportedGlibc/:0/g' \

"/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js"

This works great, but I would still like to +1 for an official option to remove the banner

cameroncc avatar Feb 12 '24 17:02 cameroncc

@apivovarov on macOS Sonoma the command to change workbench.desktop.main.js gives a permission denied error, even for root. Any thoughts?

geertj avatar Feb 12 '24 21:02 geertj

Right click on Visual Studio Code.app in Finder in Applications and select "Get Info" in drop down menu - Sharing & Permissions section (at the bottom) should show <your_user> (Me) | Read & Write

@geertj

apivovarov avatar Feb 12 '24 21:02 apivovarov

@apivovarov Thanks for taking the time to respond. It turned out that the issue was macOs SIP. Temporarily disabling SIP (requires booting into recovery mode) allowed me to change the application file.

geertj avatar Feb 12 '24 21:02 geertj

+1 please add option to remove the banner

allermat avatar Feb 13 '24 10:02 allermat

+1 Option to remove it

f1ynng8 avatar Feb 14 '24 04:02 f1ynng8

+1, would be nice to have possibility to remove the banner

niklewic avatar Feb 14 '24 09:02 niklewic

Please don't post "+1" comments, as they produce low-value email notifications to everyone watching the issue. Instead, click a reaction button on the original comment:

image

gjsjohnmurray avatar Feb 14 '24 10:02 gjsjohnmurray

this is absurd... it feels passive aggressive.

There's a simple solution for all of this.

Give us the warning that it is unsupported, but allow us to continue working on legacy boxes indefinitely.

Let us dismiss this ridiculous banner forever.

Don't fight developers, work with us.

adamcolon avatar Feb 14 '24 17:02 adamcolon

VSCode is open-source project. BUT... If you build VSCode from source (with your modifications) the application will not have the same functionality as officially distributed VSCode. For example, all Extensions will not be available.

apivovarov avatar Feb 14 '24 23:02 apivovarov

By info from @pento, i do the same but for Windows, and it works too like this:

  • Open C:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\workbench.desktop.main.js

  • Search for return X.create("vs/workbench/contrib/remote/browser/remoteConnectionHealth",e), and replace it with return null;

  • Restart VS Code;

  • After reboot you will see another bunner, about your version is broken, but you can just press on settings and click Don't show again

Microsoft, this not only for Windows, with every day updates, stop make anything to waste time of everywone!)

nikitazykov avatar Feb 15 '24 13:02 nikitazykov

I guess the ultimate question to ask here is why suddenly without any clear and strong precaution/warning/notice dropped the support for older OS, given the fact that for example centos7 hasn't been officially EOL yet.

melspectrum avatar Feb 15 '24 14:02 melspectrum

I guess the ultimate question to ask here is why suddenly without any clear and strong precaution/warning/notice dropped the support for older OS, given the fact that for example centos7 hasn't been officially EOL yet.

#203375 #203967 Don't ask that. they will lock this issue too with "Too heated"...

kohs100 avatar Feb 15 '24 14:02 kohs100