vscode icon indicating copy to clipboard operation
vscode copied to clipboard

snap: Use native wayland client when possible

Open 3v1n0 opened this issue 2 years ago • 5 comments
trafficstars

Electron supports wayland natively since version 12, but when running code from the snap it's not possible to use because of some issues.

Handle them here so that a native client can be used when in wayland (unless DISABLE_WAYLAND env variable is used), making code to have proper rendering in HiDPI screens.

This behavior can be reverted using snap set code wayland-native=false.

Before: Schermata del 2023-11-24 18-24-39

After: Schermata del 2023-11-24 18-25-24

3v1n0 avatar Nov 24 '23 18:11 3v1n0

@microsoft-github-policy-service agree

3v1n0 avatar Nov 24 '23 18:11 3v1n0

For the wayland changes, I would like to avoid auto being the default for reasons mentioned in https://github.com/microsoft/vscode/pull/186993#pullrequestreview-1523395193. Also in favor of not just making a snap specific solution, it would be great if you can provide a runtime argument to support the ozone-platform-hint flags which can then be used across deb, rpm packages as well.

I see, I can definitely revert this to be opt-in.

For the hiDPI changes, can you separate them into a different PR and provide additional context on the bug would be great.

That's the same change :), I mean, enabling wayland native client makes code to support native scaling.

3v1n0 avatar Nov 27 '23 11:11 3v1n0

Is there any progress on this?

H-G-Hristov avatar Jan 23 '24 19:01 H-G-Hristov

@deepak1556 Could you update your review? Would really like to see this merged with Wayland becoming the default in KDE 6.

cjwilsontech avatar Mar 06 '24 21:03 cjwilsontech

@deepak1556 this is rebased now, please give it another look.

3v1n0 avatar May 29 '24 15:05 3v1n0