vscode
vscode copied to clipboard
snap: Use native wayland client when possible
Electron supports wayland natively since version 12, but when running code from the snap it's not possible to use because of some issues.
Handle them here so that a native client can be used when in wayland (unless DISABLE_WAYLAND env variable is used), making code to have proper rendering in HiDPI screens.
This behavior can be reverted using snap set code wayland-native=false.
Before:
After:
@microsoft-github-policy-service agree
For the wayland changes, I would like to avoid auto being the default for reasons mentioned in https://github.com/microsoft/vscode/pull/186993#pullrequestreview-1523395193. Also in favor of not just making a snap specific solution, it would be great if you can provide a runtime argument to support the ozone-platform-hint flags which can then be used across deb, rpm packages as well.
I see, I can definitely revert this to be opt-in.
For the hiDPI changes, can you separate them into a different PR and provide additional context on the bug would be great.
That's the same change :), I mean, enabling wayland native client makes code to support native scaling.
Is there any progress on this?
@deepak1556 Could you update your review? Would really like to see this merged with Wayland becoming the default in KDE 6.
@deepak1556 this is rebased now, please give it another look.