vscode icon indicating copy to clipboard operation
vscode copied to clipboard

The JS/TS language service crashed when using Remote - SSH in 1.79.x

Open colinaaa opened this issue 2 years ago • 7 comments

Type: Bug

The same repo works fine with 1.78.2 & Remote - SSH. It also works fine with 1.79.1 without Remote - SSH.

The prettier plugin also crashed on 1.79.x, with following error:

TypeError: Cannot read properties of undefined (reading 'uid')
	at Object.statSync (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/node_modules/graceful-fs/polyfills.js:313:17)
	at p (/home/colin/.vscode-server/extensions/esbenp.prettier-vscode-9.13.0/dist/extension.js:1:35221)
	at L (/home/colin/.vscode-server/extensions/esbenp.prettier-vscode-9.13.0/dist/extension.js:1:37052)
	at /home/colin/.vscode-server/extensions/esbenp.prettier-vscode-9.13.0/dist/extension.js:1:36677
	at Function.e.exports [as sync] (/home/colin/.vscode-server/extensions/esbenp.prettier-vscode-9.13.0/dist/extension.js:1:36723)
	at t.ModuleResolver.findPkg (/home/colin/.vscode-server/extensions/esbenp.prettier-vscode-9.13.0/dist/extension.js:1:7297)
	at t.ModuleResolver.getPrettierInstance (/home/colin/.vscode-server/extensions/esbenp.prettier-vscode-9.13.0/dist/extension.js:1:3251)
	at t.default.handleActiveTextEditorChanged (/home/colin/.vscode-server/extensions/esbenp.prettier-vscode-9.13.0/dist/extension.js:1:9781)
	at handleActiveTextEditorChangedSync (/home/colin/.vscode-server/extensions/esbenp.prettier-vscode-9.13.0/dist/extension.js:1:9383)
	at b.invoke (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:63:145)
	at deliver (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:63:2121)
	at n.fire (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:63:1729)
	at /home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:104:17303
	at b.invoke (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:63:145)
	at deliver (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:63:2121)
	at n.fire (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:63:1729)
	at e.ExtHostDocumentsAndEditors.acceptDocumentsAndEditorsDelta (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:102:14003)
	at e.ExtHostDocumentsAndEditors.$acceptDocumentsAndEditorsDelta (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:102:12318)
	at s.N (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:112:11717)
	at s.M (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:112:11435)
	at s.H (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:112:10516)
	at s.G (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:112:9494)
	at /home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:112:8282
	at b.invoke (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:63:145)
	at deliver (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:63:2121)
	at n.fire (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:63:1729)
	at p.fire (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:73:14783)
	at /home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:128:32461
	at b.invoke (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:63:145)
	at deliver (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:63:2121)
	at n.fire (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:63:1729)
	at p.fire (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:73:14783)
	at D.E (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:73:18830)
	at /home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:73:16818
	at b.invoke (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:63:145)
	at deliver (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:63:2121)
	at n.fire (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:63:1729)
	at h.acceptChunk (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:73:12514)
	at /home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:73:11801
	at b.invoke (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:63:145)
	at deliver (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:63:2121)
	at n.fire (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:63:1729)
	at E.u (/home/colin/.vscode-server/bin/4cb974a7aed77a74c7813bdccd99ee0d04901215/out/vs/workbench/api/node/extensionHostProcess.js:128:20017)

VS Code version: Code 1.79.1 (4cb974a7aed77a74c7813bdccd99ee0d04901215, 2023-06-12T16:17:16.971Z) OS version: Darwin arm64 22.5.0 Modes: Remote OS version: Linux x64 5.4.56.bsk.10-amd64

System Info
Item Value
CPUs Apple M2 Max (12 x 24)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) 2, 3, 3
Memory (System) 96.00GB (24.13GB free)
Process Argv --crash-reporter-id 678f87a4-007a-4f22-acfa-2af6f220abfd
Screen Reader no
VM 0%
Item Value
Remote SSH: dev
OS Linux x64 5.4.56.bsk.10-amd64
CPUs Intel(R) Xeon(R) Platinum 8260 CPU @ 2.40GHz (32 x 2400)
Memory (System) 62.28GB (56.48GB free)
VM 100%
Extensions (22)
Extension Author (truncated) Version
project-manager ale 12.7.0
authenticator byt 0.3.3
remotehub Git 0.58.0
better-cpp-syntax jef 1.17.2
remote-containers ms- 0.295.0
remote-ssh ms- 0.103.2023060715
remote-ssh-edit ms- 0.86.0
remote-explorer ms- 0.5.2023060509
remote-repositories ms- 0.36.0
remote-server ms- 1.2.1
material-icon-theme PKi 4.28.0
rewrap stk 17.8.0
material-theme zhu 3.15.17
cannycoder byt 2.2.10
gallery byt 0.6.13
vscode-eslint dba 2.4.0
gitlens eam 13.6.0
prettier-vscode esb 9.13.0
todo-tree Gru 0.0.226
vscode-clangd llv 0.1.24
code-spell-checker str 2.20.5
vscode-lldb vad 1.9.2

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931:30280409
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30410667
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
vsccc:30610678
282f8724:30602487
pyind779:30671433
f6dab269:30613381
pythonsymbol12:30671437
showlangstatbar:30737416
vsctsb:30748421
pythonms35:30701012
03d35959:30757346
57b77579:30736110
pythonfmttext:30731395
pythoncmv:30756943
fixshowwlkth:30730052
hideindicator:30766889
pythongtdpath:30739704
bgfeh915:30763804
dh2dc718:30763024
pythonnosmt12:30765603

colinaaa avatar Jun 14 '23 08:06 colinaaa

I’m having the same issue, temporary solution was to downgrade to previous version of VS code, waiting for this bug to be fixed.

stefanvlad91 avatar Jun 14 '23 13:06 stefanvlad91

Same issue when connecting from my desktop to my macbook pro m1

Metal-spoon avatar Jun 14 '23 15:06 Metal-spoon

Does this reproduce in the latest VS Code insiders build with all extensions disabled (besides ssh)?

mjbvz avatar Jun 14 '23 20:06 mjbvz

Does this reproduce in the latest VS Code insiders build with all extensions disabled (besides ssh)?

Yes, lang server keeps crashing on insider build with everything disabled except ssh. Extension host (remote) produces the following error output:

Error: Debug Failure. Unhandled declaration kind! ModuleDeclaration for { name: export=; flags: ExportDoesNotSupportDefaultModifier|Property|ValueModule|ExportHasLocal|Module|Namespace|AccessorExcludes|GetAccessorExcludes|SetAccessorExcludes|PropertyOrAccessor|MethodExcludes|ClassMember|ValueModuleExcludes|FunctionExcludes|FunctionScopedVariableExcludes|Value|BlockScopedVariableExcludes|ParameterExcludes|RegularEnumExcludes|ClassExcludes|ConstEnumExcludes|EnumMemberExcludes|ExportValue|ModuleMember|Classifiable|Transient|All|Assignment; declarations: BinaryExpression,BinaryExpression,ModuleDeclaration }
    at getTypeOfVariableOrParameterOrPropertyWorker (/Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/node_modules/typescript/lib/tsserver.js:56277:20)
    at getTypeOfVariableOrParameterOrProperty (/Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/node_modules/typescript/lib/tsserver.js:56200:20)
    at getTypeOfSymbol (/Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/node_modules/typescript/lib/tsserver.js:56520:14)
    at Object.forEachExportAndPropertyOfModule (/Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/node_modules/typescript/lib/tsserver.js:50809:20)
    at /Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/node_modules/typescript/lib/tsserver.js:131698:17
    at /Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/node_modules/typescript/lib/tsserver.js:131601:113
    at forEachExternalModule (/Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/node_modules/typescript/lib/tsserver.js:131647:7)
    at forEachExternalModuleToImportFrom (/Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/node_modules/typescript/lib/tsserver.js:131601:3)
    at getExportInfoMap (/Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/node_modules/typescript/lib/tsserver.js:131674:5)
    at collectAutoImports (/Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/node_modules/typescript/lib/tsserver.js:157292:24)
    at getGlobalCompletions (/Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/node_modules/typescript/lib/tsserver.js:157225:5)
    at tryGetGlobalSymbols (/Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/node_modules/typescript/lib/tsserver.js:157153:352)
    at getCompletionData (/Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/node_modules/typescript/lib/tsserver.js:156919:10)
    at Object.getCompletionsAtPosition (/Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/node_modules/typescript/lib/tsserver.js:154975:26)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/node_modules/typescript/lib/tsserver.js:142037:35)
    at IpcIOSession.getCompletions (/Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/node_modules/typescript/lib/tsserver.js:181579:54)
    at completionInfo (/Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/node_modules/typescript/lib/tsserver.js:179994:43)
    at /Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/node_modules/typescript/lib/tsserver.js:182353:69
    at IpcIOSession.executeWithRequestId (/Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/node_modules/typescript/lib/tsserver.js:182345:14)
    at IpcIOSession.executeCommand (/Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/node_modules/typescript/lib/tsserver.js:182353:29)
    at IpcIOSession.onMessage (/Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/node_modules/typescript/lib/tsserver.js:182395:51)
    at process.<anonymous> (/Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/node_modules/typescript/lib/tsserver.js:183975:14)
    at process.emit (node:events:513:28)
    at emit (node:internal/child_process:939:14)
    at processTicksAndRejections (node:internal/process/task_queues:84:21)
	at Function.create (/Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/typescript-language-features/dist/extension.js:2:773291)
	at f.w (/Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/typescript-language-features/dist/extension.js:2:768613)
	at f.u (/Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/typescript-language-features/dist/extension.js:2:767696)
	at ChildProcess.<anonymous> (/Users/david/.vscode-server-insiders/bin/f3aa9a201b2455e6556797e8ffb7145d77adb792/extensions/typescript-language-features/dist/extension.js:2:767328)
	at ChildProcess.emit (node:events:513:28)
	at emit (node:internal/child_process:939:14)
	at processTicksAndRejections (node:internal/process/task_queues:84:21)

Metal-spoon avatar Jun 14 '23 23:06 Metal-spoon

@Metal-spoon Can you share a project / some code that causes that issue?

mjbvz avatar Jun 19 '23 22:06 mjbvz

@Metal-spoon Can you share a project / some code that causes that issue?

It seems it is one of the installed node modules that is causing it to crash because the project itself does not use typescript. Can't figure out which module is causing it because there are a lot in this project. Modules haven't changed between versions so this is a regression in the typescript language server.

Also seems that this is not related to SSH, the language server still crashes when working locally.

Metal-spoon avatar Jun 21 '23 22:06 Metal-spoon

Chiming in once again, using the command palette and running "TypeScript: Select TypeScript Version" and setting it to "Use Workspace Version" fixed it for me.

My workspace version is 5.0.4, I tried the TypeScript next extension (5.2.0) and that also crashes, ditto for 5.1.X So a workaround might be to just install an older TypeScript version as a dev dependency with NPM/yarn and using that.

Metal-spoon avatar Jul 09 '23 00:07 Metal-spoon

Using the workspace version(4.9.4) works for me!

colinaaa avatar Jul 10 '23 04:07 colinaaa

Hey @mjbvz, this issue might need further attention.

@colinaaa, you can help us out by closing this issue if the problem no longer exists, or adding more information.

vscodenpa avatar Sep 28 '23 11:09 vscodenpa

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

vscodenpa avatar Oct 06 '23 11:10 vscodenpa