vscode icon indicating copy to clipboard operation
vscode copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

when using profiles that enable 'Auto Detect Color Scheme', the light and dark theme maybe wrong when switch profile

Open mengld opened this issue 2 years ago • 7 comments
trafficstars

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: Version: 1.78.0-insider Commit: 3ad5774eb8123d4224eb55629df9e5f82fe13b99 Date: 2023-04-14T05:44:42.200Z (1 day ago) Electron: 22.4.5 Chromium: 108.0.5359.215 Node.js: 16.17.1 V8: 10.8.168.25-electron.0 OS: Darwin arm64 22.3.0 Sandboxed: Yes
  • OS Version: macOS Ventura 13.2.1

Steps to Reproduce:

  1. Create multiple profiles
  2. Each profile turns on Auto Detect Color Scheme and set Preferred Dark Color Theme and Preferred Light Color Theme.

in my settings, the Preferred Dark Color Theme is Github Dark, and the Preferred Light Color Theme is Github Light Theme - Gray

  1. Set the appearance to auto in macos
  2. When the system appearance is automatically switched, the vsocde current profile also switches the theme successfully at thie time, but then switching to another vscode profile, the theme does not automatically switch.

mengld avatar Apr 15 '23 06:04 mengld

but then switching to another vscode profile, the theme does not automatically switch.

Does the profile you switched to has the setting to auto detect the color scheme?

sandy081 avatar Apr 17 '23 15:04 sandy081

but then switching to another vscode profile, the theme does not automatically switch.

Does the profile you switched to has the setting to auto detect the color scheme?

yes, the profiles before and after the switch are all set to automatically detect the color scheme. thanks @sandy081

mengld avatar Apr 18 '23 13:04 mengld

I am not sure if I get it. Is it working for you now?

sandy081 avatar Apr 19 '23 19:04 sandy081

@sandy081 I speculate that the possible reason is that although multiple profiles are configured with Auto Detect Color Scheme, the vscode theme change will only be triggered when the theme of macos is switched, and when jumping to another profile, even if the theme change is set, but due to The macos theme has been switched, but there is no change at this time, it needs to switch the macos theme again to trigger. I don't understand if this is a bug. Intuitively, it should detect the current macos theme and follow the system changes when switching profiles. image image image

mengld avatar Apr 20 '23 06:04 mengld

@aeschli Assigning to you as this seems to be theme related bug. Let me know if there is anything I have to do.

sandy081 avatar May 10 '23 06:05 sandy081

This might be related to https://github.com/microsoft/vscode/issues/173770.

hamirmahal avatar Jul 07 '23 20:07 hamirmahal

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

vscodenpa avatar Aug 17 '23 12:08 vscodenpa

Should this one be considered a bug instead of a feature request?

Lutra-Fs avatar Aug 17 '23 13:08 Lutra-Fs

Should this one be considered a bug instead of a feature request?

I think https://github.com/microsoft/vscode/issues/173670 is closer to what we're looking for.

hamirmahal avatar Aug 24 '23 18:08 hamirmahal

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

vscodenpa avatar Oct 07 '23 02:10 vscodenpa

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

vscodenpa avatar Oct 17 '23 02:10 vscodenpa