vscode
vscode copied to clipboard
microsoft
Create Pull Request button is a noop
Type: Bug
Happened while I am working against a repo GitHub repo.
The SCM has a Create PR button but clicking it focuses the commit message input.
log.ts:292 TRACE CommandService#executeCommand remoteHub.createPullRequest
During branch switching my VS Code somehow ended up without GHPRI, while the Create PR button was still added by the remoteHub extension.
VS Code version: Code - Insiders 1.74.0-insider (5235c6bb189b60b01b1f49062f4ffa42384f8c91, 2022-12-05T10:19:00.076Z) OS version: Darwin x64 22.1.0 Modes: Sandboxed: Yes
System Info
| Item | Value |
|---|---|
| CPUs | Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400) |
| GPU Status | 2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: disabled_off |
| Load (avg) | 6, 5, 4 |
| Memory (System) | 64.00GB (6.87GB free) |
| Process Argv | --enable-proposed-api donjayamanne.kusto --log trace --crash-reporter-id 4cf0a6f0-aaf8-4da3-9b2b-81f6c639c12b |
| Screen Reader | no |
| VM | 0% |
Extensions (42)
| Extension | Author (truncated) | Version |
|---|---|---|
| Bookmarks | ale | 13.3.1 |
| tsl-problem-matcher | amo | 0.6.2 |
| docs-view | bie | 0.0.11 |
| emojisense | bie | 0.9.1 |
| github-markdown-preview | bie | 0.3.0 |
| markdown-checkbox | bie | 0.4.0 |
| markdown-emoji | bie | 0.3.0 |
| markdown-footnotes | bie | 0.1.1 |
| markdown-mermaid | bie | 1.15.3 |
| markdown-preview-github-styles | bie | 1.0.1 |
| markdown-yaml-preamble | bie | 0.1.0 |
| vscode-github-actions | csc | 0.24.4 |
| kusto | don | 0.3.8 |
| gitlens | eam | 2022.12.504 |
| auto-close-tag | for | 0.5.14 |
| auto-rename-tag | for | 0.1.10 |
| codespaces | Git | 1.13.2 |
| copilot-labs | Git | 0.4.488 |
| remotehub | Git | 0.46.0 |
| github-security-alerts | los | 0.0.2 |
| symbols | mig | 0.0.7 |
| theme-monokai-pro-vscode | mon | 1.2.0 |
| dotnet-interactive-vscode | ms- | 1.0.3602041 |
| isort | ms- | 2022.9.13271012 |
| python | ms- | 2022.19.13351014 |
| vscode-pylance | ms- | 2022.12.11 |
| jupyter | ms- | 2023.1.1003411034 |
| jupyter-keymap | ms- | 1.0.0 |
| jupyter-renderers | ms- | 1.0.12 |
| remote-containers | ms- | 0.266.0 |
| remote-ssh | ms- | 0.93.2022112815 |
| remote-ssh-edit | ms- | 0.84.0 |
| azure-repos | ms- | 0.23.2022120501 |
| remote-repositories | ms- | 0.25.2022120501 |
| remote-server | ms- | 1.0.0 |
| vscode-selfhost-test-provider | ms- | 0.3.10 |
| vsliveshare | ms- | 1.0.5788 |
| vscode-xml | red | 0.22.0 |
| vscode-yaml | red | 1.10.1 |
| vscode-mdx | uni | 1.0.3 |
| volar | Vue | 1.0.11 |
| markdown-all-in-one | yzh | 3.5.0 |
(1 theme extensions excluded)
@digitarald is this on desktop in a virtual GitHub repository or desktop in a local repository clone?
VS Code somehow ended up without GHPRI
Did you disable the GHPRI extension by workspace?
Remote GitHub repo (distro), so I assume virtual (unsure how they are defined).
This is weird, the GHPRI extension install should be shared across local windows (with remote workspaces the GHPRI extension needs to be installed on the remote agent). @sandy081 do you know what's going on here?
@sandy081
Steps: Opened remote repo on Desktop (which has GHPRI installed). Committed changes into a new branch. Hit the Create PR button. Actual Result: The commit field gets focused, nothing else happens Expected Result: Create PR view opens.
I had to install GHPRI again into the remote repo session to fix it.
@sandy081 sorry, the issue seems to be that somehow @digitarald is getting the GHPRI extension uninstalled for local desktop VS Code in remote repositories when switching branches.
@digitarald Just wanted to double check if the GHPRI extension exists before? Are you able to repro this? If so, can you please share the Shared log?