Quick input list dom nodes hang around after quick input dismissed

[mjbvz]

Type: Bug

1. Open dev tools
2. Open quick input and start typing a file name
3. Close the quick input with escape
4. In the devtools, look at the quick input dom

Bug The list elements for the previously showing quick input are still around

While they are cleaned up once the quick input shows again, for performance it would be better to free them once the input closes and they are no longer needed

VS Code version: Code - Insiders 1.73.0-insider (Universal) (bd1b7a384f8a5ab9fb5a6a0e8fea370e589f43a3, 2022-10-11T09:27:32.881Z) OS version: Darwin x64 21.6.0 Modes: Sandboxed: Yes

System Info

Item	Value
CPUs	Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: disabled_off
Load (avg)	5, 5, 5
Memory (System)	32.00GB (0.03GB free)
Process Argv	--crash-reporter-id 48781ca2-1705-4f64-9bab-325055aab55d
Screen Reader	no
VM	0%

[TylerLeonhardt]

I think this works the way that it does because it's possible to call show on a quick pick when a quick pick is already visible so the logic was put in the show. We can probably move it to a helper function and run it in both places.

[TylerLeonhardt]

@mjbvz didn't you fix this one in a PR? I can't seem to find it.

[mjbvz]

@TylerLeonhardt Nope. Not too familiar with the quick fix code so was waiting for you

[TylerLeonhardt]

reopening since I need to revert the fix: https://github.com/microsoft/vscode/pull/168489