vscode icon indicating copy to clipboard operation
vscode copied to clipboard

Search Tree

Open andreamah opened this issue 2 years ago • 3 comments

Shows the search results in a toggle-able tree.

image image

Fixes #20224 Fixes #161141

TODO: write tests

andreamah avatar Sep 16 '22 00:09 andreamah

any setting to enable this?

tjx666 avatar Sep 19 '22 09:09 tjx666

any setting to enable this?

It's not in the editor yet, this PR needs to be merged first 🙂

andreamah avatar Sep 19 '22 18:09 andreamah

Another thing I thought of - the selected state should be persisted when I reload the window. Either per-workspace or globally - we can check what scm does.

roblourens avatar Sep 20 '22 20:09 roblourens

Thanks for implementing this long awaited feature, I just made a test on latest insider in pressing the Collapse All button twice raised an error: TreeError [SearchView] Tree element not found: [object Object]

image

The tree view also miss the in-tree filtering (CTRL+F) like the one for files: image

ypapouin avatar Sep 23 '22 07:09 ypapouin

Thanks for implementing this long awaited feature, I just made a test on latest insider in pressing the Collapse All button twice raised an error: TreeError [SearchView] Tree element not found: [object Object]

image

The tree view also miss the in-tree filtering (CTRL+F) like the one for files: image

Tracking these issues in #161616 and #161617. Thanks for testing it out 😊

andreamah avatar Sep 23 '22 15:09 andreamah

THANK YOU 💙

bow

iamandrewluca avatar Oct 06 '22 19:10 iamandrewluca

Respect 👍🏿

tranngocson1996 avatar Nov 03 '22 05:11 tranngocson1996