vscode icon indicating copy to clipboard operation
vscode copied to clipboard

New rebase conflicts resolution completely broken. Diff worse than before.

Open alexisfrjp opened this issue 3 years ago • 0 comments
trafficstars

Version: 1.70.0 Commit: da76f93349a72022ca4670c1b84860304616aaa2 Date: 2022-08-04T04:38:48.541Z Electron: 18.3.5 Chromium: 100.0.4896.160 Node.js: 16.13.2 V8: 10.0.139.17-electron.0 OS: Linux x64 4.18.0-408.el8.x86_64

I rebase a branch with a single word different, I get everything as a conflict and can't see where is the difference is.

The diff engine is seriously damaged...

3-way merge

only user_rst vs usr_rst image

2-way merge

image vs image

I should see only the line with the user_rst shown as a conflict, not the tens of lines I currently have.

VSCode should also try to be coherent on naming, 3-way doesn't exist even though it's named like that 3-way merge in the release note and everywhere else. image

Even disabling the Merge Editor still opens a window with the conflicts... image

alexisfrjp avatar Aug 10 '22 06:08 alexisfrjp

Yep completely broken for me too!

Ryanv030 avatar Aug 10 '22 18:08 Ryanv030

@alexisfrjp I just reverted to 1.69.0 and all is working fine again!

Ryanv030 avatar Aug 10 '22 18:08 Ryanv030

Even disabling the Merge Editor still opens a window with the conflicts...

Unfortunately you need to reload/restart VS Code after toggling that setting.

Can you share details of your merge conflict?

hediet avatar Aug 11 '22 15:08 hediet

/duplicate #156608

hediet avatar Aug 12 '22 13:08 hediet

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

vscodenpa avatar Aug 12 '22 13:08 vscodenpa