vscode icon indicating copy to clipboard operation
vscode copied to clipboard

Use pointer cursor instead of hand cursor when hovering over button

Open Shomnipotence opened this issue 1 year ago • 16 comments

- What it looks now

normal cursor image

Hand Cursor when hovering over the button image

Although we know that these buttons are essentially hyperlinks, we still want to erase this distinction.It should use a normal pointer cursor in the button like apps developed with other frameworks.

Including Sidebar Item image

Menu Item image

Tabs

Explorer

Statusbar Item

- What it should be

When hovering over the button, it should be a normal cursor, like in other apps.

For example, setting the left navigation item of the app image

Most of the itmes have Highlight , so the hand pointer is uesless All the apps built by WinForms,WPF,UWP or WinUI3,Qt or other frames did not have this bug(may you think that it is a feature)

Shomnipotence avatar Aug 07 '22 12:08 Shomnipotence

I think the hand cursor is intended as a hint that you can drag the activity bar icons, for example to reorder them or move them to the side panel.

gjsjohnmurray avatar Aug 07 '22 16:08 gjsjohnmurray

I think the hand cursor is intended as a hint that you can drag the activity bar icons, for example to reorder them or move them to the side panel.

What is the reason of hand cursor on Menu Highlight Item? image

Shomnipotence avatar Aug 08 '22 01:08 Shomnipotence

I somewhat agree with this but let's keep this issue open as a feature request to gather more feedback fyi @sandy081

isidorn avatar Aug 08 '22 14:08 isidorn

By changing the pointer it's more obvious when the pointer is over an actionable menu item. When over a disabled one the pointer remains an arrow. This is consistent with what happens when pointing at action buttons in the UI.

gjsjohnmurray avatar Aug 08 '22 14:08 gjsjohnmurray

By changing the pointer it's more obvious when the pointer is over an actionable menu item. When over a disabled one the pointer remains an arrow. This is consistent with what happens when pointing at action buttons in the UI.

Most of the itmes have Highlight Status , so the hand pointer is uesless

All the apps built by WinForms,WPF,UWP or WinUI3,Qt or other frames did not have this bug(may you think that it is a feature)

Shomnipotence avatar Aug 08 '22 14:08 Shomnipotence

VS Code's behaviour in this area is consistent with how the GitHub web UI behaves for me.

gjsjohnmurray avatar Aug 08 '22 15:08 gjsjohnmurray

Agreed with @gjsjohnmurray. Its consistent now across VS Code to use hand cursor for all items those are clickable.

CC @misolori

sandy081 avatar Aug 08 '22 16:08 sandy081

@misolori I don't think all the clickable items should use hand cursor.

It's inconsistent with Windows' default behavior, buttons are not hyperlinks, this is an app not a website.

Shomnipotence avatar Aug 08 '22 16:08 Shomnipotence

this is an app not a website

https://code.visualstudio.com/blogs/2021/10/20/vscode-dev

gjsjohnmurray avatar Aug 08 '22 16:08 gjsjohnmurray

this is an app not a website

https://code.visualstudio.com/blogs/2021/10/20/vscode-dev

Yes I know. But Outlook is a website, too. And the Office Online.

Shomnipotence avatar Aug 08 '22 16:08 Shomnipotence

In the past, we've discussed whether we should drop the hand cursor and the team consensus was that it's still needed for the web but on desktop, we need to ensure we still have hover feedback as an alternate. I can bring this up again in our UX Sync.

miguelsolorio avatar Aug 08 '22 19:08 miguelsolorio

Maybe we should change it only for context menus and the top menu? The pointer elsewhere in the UI is a good thing imo and a big change.

Tyriar avatar Aug 08 '22 20:08 Tyriar

Maybe we should change it only for context menus and the top menu? The pointer elsewhere in the UI is a good thing imo and a big change.

the explorer has highlight,so it does not need hand cursor

image

Shomnipotence avatar Aug 09 '22 00:08 Shomnipotence

I think it is better to do something else like adding GUI for launch.json instead of arguing on this trivial issue.

RayGicEFL avatar Aug 09 '22 03:08 RayGicEFL

I think it is better to do something else like add GUI for launch.json instead of arguing on this trivial issue.

I am agree with “GUI for launch.json”, but I think the cursor is important,too.

Shomnipotence avatar Aug 09 '22 05:08 Shomnipotence

I agree with you, this exacerbates the widespread UI inconsistencies on Windows. All this is telling users: this software is a front-end developed by the web, this software is Win32, this software is UWP, this software is developed for a very long time...

Hardiol avatar Aug 10 '22 10:08 Hardiol

Brought this up in our ux sync today and the consensus was:

  • We should explore this in the next iteration, early on
  • Revisit areas that don't provide hover feedback
  • Show underlines for blue links (since the pointer was the main feedback)
  • Read the OS guidelines for mac/win/linux to see if there are guidance
  • Possibly keep things consistent across platforms

So we'll start exploring this in our next iteration. Here's a demo of it working in misolori/promising-mammal-pointer

https://user-images.githubusercontent.com/35271042/183965999-b25dc53c-a18c-4e36-942b-966b7375de70.mp4

miguelsolorio avatar Aug 10 '22 15:08 miguelsolorio

今天在我们的用户体验同步中提出了这一点,共识是:

  • 我们应该在下一次迭代中尽早探索这个
  • 重新访问不提供悬停反馈的区域
  • 显示蓝色链接的下划线(因为指针是主要反馈)
  • 阅读 mac/win/linux 的操作系统指南,看看是否有指南
  • 可能保持跨平台的一致性

因此,我们将在下一次迭代中开始探索这一点。这是一个在misolori/promising-mammal-pointer中工作的演示

CleanShot.2022-08-10.at.08.48.45.mp4

This is a great start!

But in this earliest version I need to point out (though I know this is just an early demo of yours):

In macOS, the search box does not have a hover highlight effect. On Windows and macOS, there is no hover change for normal buttons (there used to be a Reveal effect during the Windows 10 Creators Update)

_reveal-highlight-fluent-design-demo

@misolori

Shomnipotence avatar Aug 11 '22 01:08 Shomnipotence

Assigning this back to the backlog since we will not have time in September to think about this. Also unassigning myself so design ca drive this. I personally think both options are fine.

isidorn avatar Sep 23 '22 18:09 isidorn

Assigning this back to the backlog since we will not have time in September to think about this. Also unassigning myself so design ca drive this. I personally think both options are fine.

I think the design study is over based on @miguelsolorio 's feedback, the conclusion is clear, we should use the default cursor instead of the hand cursor in the hover effect on the desktop

Shomnipotence avatar Sep 24 '22 14:09 Shomnipotence

Brought this up in our ux sync today and the consensus was:

  • We should explore this in the next iteration, early on
  • Revisit areas that don't provide hover feedback
  • Show underlines for blue links (since the pointer was the main feedback)
  • Read the OS guidelines for mac/win/linux to see if there are guidance
  • Possibly keep things consistent across platforms

So we'll start exploring this in our next iteration. Here's a demo of it working in misolori/promising-mammal-pointer

CleanShot.2022-08-10.at.08.48.45.mp4

I don't know why the assignment was removed, I think the conclusion of the design study is clear that this is a change that must be made.

Shomnipotence avatar Sep 24 '22 14:09 Shomnipotence

I don't know why the assignment was removed

@Shomnipotence it has been reassigned to @daviddossett because @miguelsolorio has left the team.

gjsjohnmurray avatar Sep 24 '22 14:09 gjsjohnmurray

I don't know why the assignment was removed

@Shomnipotence it has been reassigned to @daviddossett because @miguelsolorio has left the team.

I don't think it's necessary, the design research is over, the conclusions have been made, and it's time for the developers to perform.

Shomnipotence avatar Sep 25 '22 00:09 Shomnipotence

@Shomnipotence the issue is still open and assigned, so it's valid. I understand you're passionate about this, but try to keep in mind that every comment results in notifications being sent to many people.

Tyriar avatar Sep 26 '22 13:09 Tyriar

After paying attention to this topic for a long time, what was the final conclusion regarding this topic? When will the cursor transition from the hand cursor back to the normal pointer cursor when hovering over tab pages, the left toolbar, and the menu bar?

Ryutaku avatar Jun 27 '23 08:06 Ryutaku

When the mouse hovers over the menu bar, left toolbar, and tab pages, the cursor displayed as a hand shape makes me very uncomfortable and unfamiliar.

Ryutaku avatar Jun 27 '23 08:06 Ryutaku

No updates here yet. It's in the backlog an we'll revisit this when we have more bandwidth.

daviddossett avatar Jun 28 '23 17:06 daviddossett

The issue I have with the hand cursor is it blocks the tooltip and I have trouble reading it.

crizzo-xerox avatar Jul 21 '23 15:07 crizzo-xerox