vscode icon indicating copy to clipboard operation
vscode copied to clipboard

Terminal colors are muted with gpuAcceleration on

Open connor4312 opened this issue 3 years ago • 7 comments

I noticed terminal colors were off the other day; I thought it was the new ultrawide monitors we got in the office, but it's not. Top is with

"terminal.integrated.gpuAcceleration": "off",

image

"terminal.integrated.gpuAcceleration": "auto",

image

Notice the red is much less vibrant. It appears to go away if I set terminal.integrated.minimumContrastRatio: 0, but I had thought that was supposed to be the same for all rendering modes.

connor4312 avatar Jul 27 '22 22:07 connor4312

what happens if you set it to on?

meganrogge avatar Jul 27 '22 22:07 meganrogge

changing that setting doesn't change the color for me 🤔

meganrogge avatar Jul 27 '22 22:07 meganrogge

my min contrast ratio is the default - 4.5

meganrogge avatar Jul 27 '22 22:07 meganrogge

contrast gets worse when I change contrast ratio from 0 to 4.5 🤔 .... that seems wrong

meganrogge avatar Jul 27 '22 22:07 meganrogge

Previous reports like this have had the canvas colors correct to the theme and the dom not due to electron bugs. Could be it?

Tyriar avatar Jul 28 '22 00:07 Tyriar

@deepak1556 have you seen reports like this?

meganrogge avatar Aug 02 '22 19:08 meganrogge

Upstream https://github.com/xtermjs/xterm.js/issues/4008

Tyriar avatar Aug 10 '22 12:08 Tyriar

Cannot reproduce

Tyriar avatar Dec 16 '22 18:12 Tyriar