vscode icon indicating copy to clipboard operation
vscode copied to clipboard

Wrapped extension categories don't look good

Open Tyriar opened this issue 2 years ago • 8 comments

Actual:

image

Expected:

image

Tyriar avatar May 23 '22 17:05 Tyriar

Hi, I'm new to vscode's code base, but I'm interested in contributing. Can I take a stab at this?

danilhendrasr avatar Jun 03 '22 03:06 danilhendrasr

Definitely

sandy081 avatar Jun 03 '22 07:06 sandy081

My apologies @danilhendrasr 🙏, made a pull request, did not notice that the task was already taken.

Btw, the request has not been accepted yet, I think there may be several iterations of improvements

lgordey avatar Jun 05 '22 10:06 lgordey

Well that was unfortunate, I was looking forward to my first contribution to vscode 😕

danilhendrasr avatar Jun 05 '22 23:06 danilhendrasr

I guess it's okay, I'll keep an eye on other issues.

danilhendrasr avatar Jun 05 '22 23:06 danilhendrasr

I don't think it's possible to achieve what's being attempted in the linked PR with CSS alone. It seems like you would need some JS event listeners to calculate when the style should collapse.

Alternatively, you could just set the width to max-content and avoid the blocks all-together, it behaves consistently with no wasted whitespace:

https://user-images.githubusercontent.com/40288183/183332374-d1b96e41-e64f-432f-9bba-81aca97ab44e.mov

purplecomet1 avatar Aug 08 '22 03:08 purplecomet1

@purplecomet1 I was going to suggest the same thing of using width: max-content;, seems like a good solution.

philecker avatar Aug 25 '22 15:08 philecker

can i take up this task ? If it is still unresolved and needs correction

GargDivanshu avatar Sep 21 '22 16:09 GargDivanshu

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!

vscodenpa avatar Dec 06 '22 13:12 vscodenpa