vscode Remove the notebookContentProvider API proposal

The notebookContentProvider API proposal is currently not on track for finalization. This api was introduced when we were still figuring out the model for working with notebooks and was inspired by the custom editor api. However we ultimately went with the much simpler NotebookSerializer API

Parts of the notebookContentProvider API are not well tested or supported today and maintaining it adds complexity to VS Code. We'd like to remove it, however the API is currently used by (or at least enabled for):

[ ] Liveshare @alyssajotice @fubaduba (please copy correct owners if I got them wrong
[x] Dot net interactive @brettfo, @colombod

Please let us know if/how you are using the notebookContentProvider api and if there are any factors that would block you from migrating off of it

Apr 11 '22 19:04 mjbvz

@mjbvz we should have what we need to migrate here: https://github.com/microsoft/vscode/issues/125757. I expect to have this done by the end of the month. I'll update this thread when we've stopped using it.

Apr 11 '22 22:04 alyssajotice

@mjbvz here is an update: https://github.com/microsoft/vscode/issues/125757#issuecomment-1101818621

Apr 18 '22 22:04 alyssajotice

@alyssajotice How's Liveshare's migration been going? Run into any blockers or have any questions?

May 23 '22 22:05 mjbvz

Hey @mjbvz, I am currently working on the design docs for this. This will be a large, three-part change to the Live Share notebooks architecture, and our goal is to have this done by the fall. I'll send you the design doc when it is complete so you can stay up to date.

May 25 '22 19:05 alyssajotice

Looks like liveshare is not using save, saveAs, or backup. Let's remove these from the proposal entirely

Sep 09 '22 23:09 mjbvz

All external consumers have now migrated off this api

We just need to move our tests off of this api and then we can remove it entirely: https://github.com/microsoft/vscode/issues/160580

Oct 24 '22 20:10 mjbvz