vscode-webview-ui-toolkit icon indicating copy to clipboard operation
vscode-webview-ui-toolkit copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Button uses wrong background on hover with light HC theme

Open daviddossett opened this issue 3 years ago • 2 comments

CleanShot 2022-03-31 at 10 25 12

daviddossett avatar Mar 31 '22 17:03 daviddossett

It appears this is related to this behavior:

https://github.com/microsoft/vscode-webview-ui-toolkit/blob/3ba70540550ebe53a6010cacd7ff1a1d4c612d3e/src/utilities/theme/applyTheme.ts#L56-L60

I'm slightly confused why removing this as a sanity check doesn't work since these values are indeed explictly set in VS Code core. Note the hcLight value set here:

https://github.com/microsoft/vscode/blob/6fcf02f29a125db24f67bd9dc43110a02773edf0/src/vs/platform/theme/common/colorRegistry.ts#L269

Is this related to how the tokens are supplied to webviews?

daviddossett avatar Apr 01 '22 21:04 daviddossett

VS Code now tells webviews about hc-light so I can pick this up later this week or next.

daviddossett avatar Jun 21 '22 15:06 daviddossett