vscode-textmate icon indicating copy to clipboard operation
vscode-textmate copied to clipboard
verified publisher icon microsoft

Empty `end` match immediately

Open RedCMD opened this issue 9 months ago • 5 comments

fixes #251

RedCMD avatar Apr 01 '25 13:04 RedCMD

wouldn't it make sense if you include a test case for such a subtle bug/edge case?

sebthom avatar Apr 02 '25 08:04 sebthom

a contributing doc to explain how to add tests would have been nice instead of me having to reverse engineer this repo luckily https://github.com/microsoft/vscode-textmate/commit/7640bd6490ad961437a6982d7489e212777df7d8 is a clean commit to copy

RedCMD avatar Apr 02 '25 10:04 RedCMD

@alexdima would you mind having a look thanks

this replaces the bad fix 7640bd6 for https://github.com/microsoft/vscode-textmate/issues/66

RedCMD avatar Apr 18 '25 10:04 RedCMD

@alexdima @lszomoru @joaomoreno I noticed you were able to create and merge your own PR within a few hours. It would be greatly appreciated if you could also take a look at this community-provided PR, which has been waiting for review for over 6 months. It addresses an existing bug and deserves attention so it doesn’t get lost.

sebthom avatar Oct 04 '25 19:10 sebthom