microsoft
Load referenced grammars lazily
From https://github.com/microsoft/vscode/issues/77990
Problem When loading a grammar that references other grammars, we currently always pull in the referenced grammars eagerly. For languages like markdown that reference a large number of grammars, this can be quite expensive.
Proposed Fix If possible, we should investigate to see if we can resolve these referenced grammars lazily instead. For example, the markdown grammar should only load the pug grammar when it actually encounters a pug fenced code block while tokenizing text
/cc @alexandrudima
After debugging through the code, I think we could look into making getExternalGrammar both load and init external grammars. Right now, we eagerly load the external grammars in Registry._loadGrammar and then getExternalGrammar lazily loads it
This may be problematic however as RegistryOptions.loadGrammar returns a promise and getExternalGrammar is called from a fairly low level that is not async
I think this is a nice thing to have, but consider that tokenizeLine/tokenizeLine2 are synchronous methods and loading grammars is asynchronous (in VS Code it is wired to go through the IFileService), so IMHO this is not something straight-forward to do. Are there other editors that use TM and which load grammars lazily?
So far, this has been a limitation that was well understood and that impacted only markdown. In fact, I wrote a fast plist parser especially for markdown due to this and at the time the impact for loading markdown was in the 100ms-200ms range. See https://github.com/microsoft/vscode/issues/8173 .
IMHO, I think the markdown performance and the TS performance should be treated as two separate issues, because one was well understood and accepted since years and is caused by really needing to load a lot of other languages, and the other one was (unnecessarily) introduced via injection to TypeScript.
Yeah I realized this is too far down in the stack to easily make async. We can fix the regression for js/ts since this is not simple. I just wanted to make sure we know that the root cause of the problem is not js/ts specific