vscode-pull-request-github icon indicating copy to clipboard operation
vscode-pull-request-github copied to clipboard

Cannot create comment on pull request based on fork

Open JackismyShephard opened this issue 2 months ago • 11 comments

  • Extension version: 0.120.1
  • VSCode Version: 1.105.1
  • OS: Windows 11, Ubuntu 24.04
  • Repository Clone Configuration : Single Repository
  • GitHub Product GitHub.com

Steps to Reproduce:

  1. Open GitHub Pull Request extension in VSCode
  2. Find a Pull request based on a branch on a fork of main repo
  3. Write a comment and press comment
  4. Error is raised: Creating comment failed: Error: File has been deleted.

JackismyShephard avatar Oct 20 '25 07:10 JackismyShephard

@alexr00 This seems to be potentially correlated with other issues like:

  • https://github.com/microsoft/vscode-pull-request-github/issues/6096

JackismyShephard avatar Oct 20 '25 08:10 JackismyShephard

Is your origin remote the main repo, the fork, or yet another fork?

alexr00 avatar Oct 20 '25 11:10 alexr00

@alexr00 I have tested two different setups: both main repo, but also fork of repo A trying to comment on PR made on another fork of A.

Crucially, there is no issue making a comment on repo A itself.

JackismyShephard avatar Oct 20 '25 14:10 JackismyShephard

This is still an issue, makes working on pull requests in vscode impossible for me. Same setup, pull requests from branches on the main repo work ok, pull requests from branches on forks are not possible to review in vscode at all

gordallott avatar Dec 05 '25 11:12 gordallott

I can repro. It only seems to happen on certain PRs. Thanks for you persistence on this.

As far as I can see it looks like an issue with the GitHub API that we're using. I've asked the GitHub folks and will report back on what they say.

alexr00 avatar Dec 05 '25 11:12 alexr00

I am dealing with this constantly. It's on our private repo - no forks

Creating comment failed: Error: File has been deleted.

Ilaiwi avatar Dec 08 '25 10:12 Ilaiwi

GitHub folks are looking at it. Unfortunately there's not much I can do from this extension as there's no other API I can try to add the comment.

alexr00 avatar Dec 08 '25 10:12 alexr00

I have suddenly started running into this for a PR I am reviewing (https://redirect.github.com/cylc/cylc-ui/pull/2370). Not had this problem before when reviewing PRs for the same repo, using the same clone. In fact I'm sure I was able to leave review comments on the same PR a few days ago.

Extension 0.122.1, VS Code 1.106.3

MetRonnie avatar Dec 09 '25 18:12 MetRonnie

I also have this issue, in the case of a PR on a fork and also for a PR on the upstream repo.

There's no information in the logs, just an error dialog with these contents

[Window Title] Visual Studio Code

[Main Instruction] Starting review failed. Any review comments may be lost.

[Content] File has been deleted.

[OK]

zaneduffield avatar Dec 10 '25 22:12 zaneduffield

I also got the same issue!

chenyukang avatar Dec 11 '25 11:12 chenyukang

It sounds like the GitHub API might be misbehaving here? Is there any tracking issue for the underlying problem that we can upvote and subscribe to?

RikkiGibson avatar Dec 11 '25 18:12 RikkiGibson

The tracking issue is internal to GitHub, so folks here can't upvote it. This issue is the best option to upvote and subscribe to.

alexr00 avatar Dec 17 '25 10:12 alexr00

The tracking issue is internal to GitHub, so folks here can't upvote it. This issue is the best option to upvote and subscribe to.

two months passed, the issue still haven't been fixed. sounds crazy.

chenyukang avatar Dec 18 '25 01:12 chenyukang