PR notification - mark notification for a created PR that was merged
Testing #6833
Here is an example that did not get marked as done when I invoked the action:
- This is a PR that I created
- There were several comments (most of them automated)
- The PR got merged successfully
I would have expected for this notification to be marked as done as well but it did not.
I could ignore bot comments.
This looks like a real comment though: https://github.com/microsoft/winget-pkgs/pull/251563#issuecomment-2834287584
I don't see a way to tell that that is not a meaningful comment.
Maybe offer a setting to filter out specific users? For our team, we'd filter out @vs-code-engineering, etc..
I'm not sure how difficult it is to determine the author of a "meaningful event". I feel that might not be feasible to do the GitHub API?
I similarly expected this PR to be marked as done: https://github.com/bamurtaugh/theCatSaidNode/pull/2.
- This is a PR I created
- There were comments from a couple users beyond my account
- I merged the PR (meaning I would've seen the comments from those other accounts, and I was the last active user in the PR)
The notification went away both in gh.com and VS Code once I commented after the merge: https://github.com/bamurtaugh/theCatSaidNode/pull/2#issuecomment-2837459689.
I can ignore comments that come from users who are outside the team, but I'm not sure I want that behavior.