vscode-pull-request-github
vscode-pull-request-github copied to clipboard
microsoft
Pressing "Esc" on a comment being written deletes the comment content while keeping the line range
- Extension version: 0.96.0
- VSCode Version: 1.93.1
- OS: MacOS Catalina
- Repository Clone Configuration (single repository/fork of an upstream repository): Single repo
- Github Product (Github.com/Github Enterprise version x.x.x): Github.com
Steps to Reproduce:
- Open a comment for a line range or even a single line
- Write something
- Close the box with "Esc"
- Re-open the same box
Expected outcome:
- Either for Esc not to close it (can probably be configured with focus settings)
- For a single line: if I re-open the same line I expect the text I was writing to still be there while I have the diff/file open, if the file is closed, the text can be gone
- For multiple lines: since it already keeps the line range, just keep the text around for the same text range until de-selected
In other, much simpler words: please don't delete the text I have because I pressed "Esc" — I'm using VSCode Vim and just deleted a big comment twice 😭
If you give me some pointers where I can look to investigate how to solve this, I can take some time to try and help!
Note: it seems that this doesn't always happen, I had a comment that was kept but I'm not sure if I left it with "Esc", but it's definitely not consistent.
I have the same problem? Have you found a work around?
Not clicking "Esc" — I wish I was joking
This is a huge show-stopper for users with vim keybindings. I can't even exit insert mode without deleting the comment.
An application should never delete text without either prompting or an undo option.
Possible duplicate of #1455.
Duplicate of https://github.com/microsoft/vscode-pull-request-github/issues/1455, will aim to add next month!
