vscode-pull-request-github icon indicating copy to clipboard operation
vscode-pull-request-github copied to clipboard

When "comment" text box is focused and "Review Pull Request" panel is in a sidebar, `sideBarFocus` does not get set to `true`

Open macintacos opened this issue 1 year ago • 0 comments

I have my primary sidebar set to be on the right side. When the "comment" textbox supplied by this extension (screenshotted below) is focused, sideBarFocus is not set to true. I know this for a fact, because I have set up a keyboard shortcut with a when clause of just sideBarFocus, and it doesn't work when I'm in that text box - if I'm in another text box in the sidebar (for example, the extension view) and I use the same shortcut, it works fine.

CleanShot 2024-08-20 at 15 30 01

  • Extension version: v0.94.0
  • VSCode Version: 1.92.2
  • Commit: fee1edb8d6d72a0ddff41e5f71a671c23ed924b9
  • Date: 2024-08-14T17:29:30.058Z
  • Electron: 30.1.2
  • ElectronBuildId: 9870757
  • Chromium: 124.0.6367.243
  • Node.js: 20.14.0
  • V8: 12.4.254.20-electron.0
  • OS: Darwin arm64 23.6.0
  • Repository Clone Configuration (single repository/fork of an upstream repository): single repository
  • Github Product (Github.com/Github Enterprise version x.x.x): Github.com

Steps to Reproduce:

  1. Create a keyboard shortcut with a when clause set to sideBarFocus. For demo purposes, I'm using the command to show the command palette (it could be anything):
{
  "key": "cmd+ctrl+space",
  "command": "workbench.action.showCommands",
  "when": "sideBarFocus"
}
  1. Go to the "Leave a comment" textbox and try invoking that shortcut. It does not do anything.
  2. Go to another panel, for example, the extensions view, click on a text box, and try to invoke the command. It works.

If this extension is in the sidebar, and my cursor is in the extension, then sideBarFocus should be true - but it's not. It's not clear to me whether or not this is a VSCode problem or a problem with this extension, however, considering that it works in other sidebar views, I want to place the blame on the extension at this point.

macintacos avatar Aug 20 '24 15:08 macintacos