vscode-pull-request-github icon indicating copy to clipboard operation
vscode-pull-request-github copied to clipboard

Have a context menu to clear review status

Open bpasero opened this issue 1 year ago • 2 comments

Here in "File" node there could be a context menu to either check or uncheck all checkboxes:

Image

bpasero avatar Jul 09 '24 06:07 bpasero

If you use a tree structure for files then you get this by checking/unchecking a folder checkbox.

A few ideas for the flat structure:

  • Support multi select, then you select all so toggling 1 checkbox would toggle all.
  • Add a checkbox on "Files"
  • Add an inline action on "File" for "mark all as viewed"/"mark all as unviewed"

alexr00 avatar Jul 09 '24 08:07 alexr00

I like the idea of multi-select!

bpasero avatar Jul 09 '24 08:07 bpasero

Once https://github.com/microsoft/vscode-pull-request-github/pull/6570 is in you can do the following for checked out PRs in the active PR view:

  • multi-select files
  • check/uncheck them
  • If your check/uncheck is part of the selection, then the entire selection will be toggled.

alexr00 avatar Dec 19 '24 14:12 alexr00

This works as mentioned above, however, it feels a bit weird to me that all checkboxes are toggled. I would have expected that all selected checkboxes have the same state after toggling one.

So if I have [ ] [x] [ ] and select all and toggle the first checkbox I would expect to end up with [x] [x] [x]. Instead I get [x] [ ] [x].

Also, this only works for the GitHub Pull Request view and not for the GitHub Pull Requests view

benibenj avatar Jan 28 '25 10:01 benibenj