vscode-pull-request-github icon indicating copy to clipboard operation
vscode-pull-request-github copied to clipboard

Allow to open PR on web from PR view when showing multiple

Open bpasero opened this issue 1 year ago • 3 comments

Here I really miss a way to click on the 🌐 icon to open the PR externally:

image

bpasero avatar May 13 '24 07:05 bpasero

@bpasero you just want to open github.com to the PR? I can add an action for this.

alexr00 avatar May 13 '24 08:05 alexr00

Yeah like this one:

image

bpasero avatar May 13 '24 08:05 bpasero

Hey there. I would like to contribute to this project and this issue would be a good starting point.

I have build the extension locally. For opening the pr on github, we can modify the menus -> view/item/context to use the existing pr.openPullRequestOnGithub command in package.json file.

Screenshot 2024-05-27 211734

Screenshot 2024-05-27 210617

I am happy to send a pull request with the required changes.

Santhoshmani1 avatar May 27 '24 15:05 Santhoshmani1

To verify:

  • Open a multi-repo workspace
  • Checkout a PR branch in more than one of your repos
  • Verify that in the "Pull Request" view, you see a globe icon next to each PR title and you can use that to open the PR on github.com.

alexr00 avatar Jul 22 '24 09:07 alexr00

the issue is verified

I was wondering if there is a reason why the earth icon appears only when there is more than one pull request checked out in the multi-repo workspace? I was expecting there to be a globe icon when there is only one PR too:

Screenshot 2024-07-23 at 16 44 24

aiday-mar avatar Jul 23 '24 14:07 aiday-mar

It shows here when there's only one:

Image

alexr00 avatar Jul 23 '24 14:07 alexr00

Ah yes I see

aiday-mar avatar Jul 23 '24 14:07 aiday-mar