vscode-pull-request-github icon indicating copy to clipboard operation
vscode-pull-request-github copied to clipboard

Custom pull request description

Open spigelli opened this issue 2 years ago • 7 comments

I always mannually enter Fixes #${issueNumber} in my descriptions, I'd like to have this done automatically. Ability to provide custom pull request description with advanced settings similar to the setting: githubIssues.issueBranchTitle

spigelli avatar Aug 11 '23 20:08 spigelli

Is this still being worked on? Would love to work on it if possible so that I could fix this problem because I like this extension but this is a feature I would like to have.

nebiyuelias1 avatar Sep 03 '24 09:09 nebiyuelias1

What is the cue that the extension can use to know which issue number to put in the PR description? Do you folks use the "work on an issue flow" ?

alexr00 avatar Sep 03 '24 14:09 alexr00

Well, for example I usually write on the description "Closes [issue number]" then GitHub automatically links the PR with the issue and when merged, the issue gets closes.

nebiyuelias1 avatar Sep 04 '24 00:09 nebiyuelias1

How should the extension know/guess which issue number should be written in the description? What information should we try to cue off of to understand which issue you want to link?

alexr00 avatar Sep 04 '24 12:09 alexr00

Oh sorry actually I have realized I misunderstood the original issue. What I want is a suggestion popup when I start writing a # just like in GitHub. Maybe I create another issue for this?

nebiyuelias1 avatar Sep 04 '24 13:09 nebiyuelias1

The "Create" view and the PR description are webviews, so we don't have completions there. That feature request is https://github.com/microsoft/vscode-pull-request-github/issues/2401.

alexr00 avatar Sep 04 '24 17:09 alexr00

Oh I see that's quite unfortunate. But after checking the source code, it seems there's a component responsible for the description input. Wouldn't it be possible to listen for changes and show the popup when someone types the # symbol. Sorry but I initially thought this was an easy thing to do. It's because I don't have a good understanding of the code I guess.

nebiyuelias1 avatar Sep 05 '24 02:09 nebiyuelias1

Closing as a duplicate of https://github.com/microsoft/vscode-pull-request-github/issues/2401.

alexr00 avatar Dec 16 '24 16:12 alexr00