vscode-pull-request-github icon indicating copy to clipboard operation
vscode-pull-request-github copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Button spacing

Open bpasero opened this issue 2 years ago • 4 comments

I feel there is quite the gap between these two buttons at the bottom:

Image

bpasero avatar Aug 10 '23 07:08 bpasero

Hm, I guess this is done to separate the concerns that are clearly different? What is the reason to have a button to "Check out main", should that maybe be just removed? I wonder how related that action is to the PR?

bpasero avatar Aug 10 '23 07:08 bpasero

The "Checkout 'main'" used to be "Exit review mode", which still just checked out main but which users found confusing. Since we checkout a branch when you check out a PR, we want to have a way to guide users off of that branch too when they're done working with the PR.

alexr00 avatar Aug 10 '23 16:08 alexr00

@hbons as well in case you have thoughts on this.

alexr00 avatar Aug 10 '23 16:08 alexr00

Adding some grouping and changing the checkout button to secondary could help here. Quick mockup:

image

hbons avatar Dec 05 '23 10:12 hbons