vscode-pull-request-github icon indicating copy to clipboard operation
vscode-pull-request-github copied to clipboard

Excessively aggressive branch name encoding in HEAD links

Open joyceerhl opened this issue 2 years ago • 0 comments

  1. https://insiders.vscode.dev/github/microsoft/vscode/tree/ben/;@&=+$
  2. Share > Copy GitHub HEAD Link
  3. Open the link
  4. :bug: GitHub says the link wasn't valid

Previously branch names weren't encoded at all https://github.com/microsoft/vscode-pull-request-github/issues/4705 but it looks like in the case above we shouldn't be encoding, since https://github.com/microsoft/vscode/tree/ben/;@&=+$ works

joyceerhl avatar Jun 02 '23 22:06 joyceerhl