vscode-pull-request-github icon indicating copy to clipboard operation
vscode-pull-request-github copied to clipboard
verified publisher icon microsoft

GHPRI does not render images in comments on vscode.dev

Open bhavyaus opened this issue 2 years ago • 6 comments

  • Extension version:
  • VSCode Version:
  • OS:

Sample comment with image in GHPRI image

On GitHub: image

bhavyaus avatar Feb 01 '23 19:02 bhavyaus

Can you share a link to the PR you're seeing this with? I'm not able to reproduce it.

alexr00 avatar Feb 02 '23 10:02 alexr00

Got a link offline. It turns out that the images in that PR are img tags and not markdown images. We only support markdown images, so these images don't render. The next question is: how did these end up as img tags and not markdown images.

alexr00 avatar Feb 03 '23 08:02 alexr00

I inserted the image via paste (Ctrl+V) after taking a screenshot. I do this with the all GitHub PRs and Issues (including this one) and see that it was also inserted with the tag.

img is supported in the description which is why I assumed we supported in the comments as well. Example pr with img in the description https://github.com/microsoft/vscode/pull/173128

bhavyaus avatar Feb 03 '23 18:02 bhavyaus

The PR description page directly uses GitHub's HTML for the comment so it renders fine there. The comment only supports makrdown though, and img isn't included in that support.

I wonder if GitHub changed something here. I've never seen an img inserted before, only the markdown syntax for an image. I'll follow up with them to see what's changed.

alexr00 avatar Feb 06 '23 10:02 alexr00

Hit the same thing today. Would be great to have this fixed, please 🙄

vittorius avatar Mar 27 '24 06:03 vittorius

Fix will go into pre-release next week, but it will only work for public repos.

alexr00 avatar Jun 28 '24 15:06 alexr00

To verify:

  1. Add a code comment, not just a comment in the PR timeline, to a public PR with an img tag in it, where the img points to a file that was uploaded to github by pasting.
  2. Open that comment in GHPR and verify you can see the img.

alexr00 avatar Jul 22 '24 10:07 alexr00

Not working, e.g. https://insiders.vscode.dev/github/microsoft/vscode/pull/223104

Broken image icons in vscode.dev PR

Some logs:

The FetchEvent for "https://github.com/user-attachments/assets/34eb7182-cf53-4931-8fd1-eec11464e627" resulted in a network error response: Cross-Origin-Resource-Policy prevented from serving the response to the client.

GET https://github.com/user-attachments/assets/34eb7182-cf53-4931-8fd1-eec11464e627 net::ERR_FAILED From markdownRenderer.ts:319 From markdownRenderer.ts:63

rzhao271 avatar Jul 23 '24 18:07 rzhao271

Looks like this is a COI issue. The fix is still good on desktop.

alexr00 avatar Jul 24 '24 09:07 alexr00