vscode-pull-request-github icon indicating copy to clipboard operation
vscode-pull-request-github copied to clipboard
verified publisher icon microsoft

user icons are not loaded for Github Enterprise in PR Detail page

Open aelam opened this issue 3 years ago • 5 comments

  • Extension version: v0.42.0
  • VSCode Version: 1.67.2
  • OS: macOS 12.6

Steps to Reproduce:

  1. open the PR list in VSCode
  2. choose one PR, it will open the PR detail (NOT the commits history of PR)
  3. You can see your own icons and comment icons in the PR detail

aelam avatar Oct 06 '22 01:10 aelam

We don't get the icons we have set in github, but we do get little robot icons. image

ericohlin avatar Oct 13 '22 21:10 ericohlin

@ericohlin Sorry for confusing you,

You check one PR detail in VSCode You can see your own icon and comments with icons I've updated the issue to be more detailed

aelam avatar Oct 14 '22 10:10 aelam

This should be starting with version 0.52.0 of the extension. If it's not, please ping the issue again and I will investigate!

alexr00 avatar Dec 09 '22 09:12 alexr00

@alexr00 Sorry for late. The fixed version shows github icon for enterprise in my case I debugged this issue, it's an authentication issue, the iconUrl was correct, the avatarUrl is like this https://<git enterprise URL>/avatars/[number]/... ~~I think the token is needed to request the icon~~

I tested attaching the token to the request, it doesn't work.

I'm not sure if there is any other way to do it.

sorry for bothering

aelam avatar Jul 12 '24 00:07 aelam

reopen

aelam avatar Aug 07 '24 10:08 aelam