microsoft
No feedback after Approve & Submit
Type: Bug
I just approved a PR in vscode. After hitting Approve and Submit the Leave a comment empties as only feedback. I was confused for a bit and had to double-check if it worked.
Should I be able to, to approve multiple times?
Maybe the description can open to show the latest comment and PR state?
Extension version: 0.49.2022082209 VS Code version: Code - Insiders 1.71.0-insider (235a92a3693176fbf9af16ec5b829c458a1d682f, 2022-08-22T05:17:16.753Z) OS version: Darwin x64 21.6.0 Modes: Sandboxed: No
Yes, github.com allows you to approve multiple times. I'll see what I can add to the focus view to make it clearer that your approve went through.
You should see your username and a checkmark after you approve and submit:
Do you not see this?
@alexr00 sorry for the delay. I just tried this out again and it does feel very hidden. One idea would be to open (focus) the PR description, as this has a much large area for completed reviews?
Maybe there are ways that we can add to our UX toolbox to highlight subtle changes in smaller UI elements like icons (cc @daviddossett)
I'd prefer to add further emphasis to the focus view rather than open the full PR description. As a user of the view myself, I don't want the whole description editor open when all I need to do is approve the PR. I'm interested in @daviddossett input on this as well!
I'll take a look at this next week—bit backed up at the moment after being OOF.
Adding on to this, currently if there's multiple reviewers on a PR it's possible your name / 'approval status' is hidden without scrolling
Coming back to this now, I think this is another good candidate for https://github.com/microsoft/vscode/issues/166891
In the meantime, would it make sense to match the colors used in the PR list here @alexr00? The icon would probably jump out more than it does now.
👍 colors added with https://github.com/microsoft/vscode-pull-request-github/pull/4329